- Feb 27, 2025
-
-
verfasst von Henning Leutz
feat: checkout template event See merge request !149
-
verfasst von Michael Danielczok
-
- Feb 26, 2025
-
-
verfasst von Patrick Müller
-
verfasst von Henning Leutz
fix: move original price styling to the Basket Control See merge request !147
-
verfasst von Michael Danielczok
Related: template-cologne#115
-
verfasst von Henning Leutz
This commit refactors the formatting and structure of the reversal method for improved readability. Additionally, it removes an unnecessary exception in the 'setCustomer' method. This commit also fixes the customer user settings in various methods in the order class. Now, whenever a customer is set or removed, the related articles will correctly update their user status.
-
- Feb 25, 2025
-
-
verfasst von Michael Danielczok
Related: #179
-
- Feb 24, 2025
-
-
verfasst von Henning Leutz
fix: update `getCustomerFiles` method signature in `AbstractOrder` See merge request !146
-
verfasst von Michael Danielczok
-
verfasst von Michael Danielczok
Related: template-cologne#119
-
- Feb 23, 2025
-
-
verfasst von Henning Leutz
Ignored various PHPStan errors in 'phpstan-baseline.neon' file due to missing classes and methods. Many of these errors were related to the ERP, Shipping, and Invoice modules. This fix suppresses the error reporting to ensure smooth operation of the rest of the code base. However, it's recommended to address these missing dependencies for a long-term solution.
-
verfasst von Henning Leutz
Rearranged conditional statement checks for better readability. This involves the check for whether the class 'QUI\\ERP\\Payments\\SEPA\\Provider' exists and if 'quiqqer/payment-sepa' package is installed.
-
verfasst von Henning Leutz
Fixed a typo in the comment of `getEntityTypeTitle` method in `OutputProviderOrder.php` file. The word "ommitted" is replaced with "omitted".
-
verfasst von Henning Leutz
Changes include: 1) In `removePos.php`, removed the usage of null safe method call, as it was not needed. 2) In `getOrderControl.php`, added a null guard before trying to get view from the OrderProcess and use it. If the method does not exist, null will be assigned to `$View`. 3) Removed unnecessary fallback to get the first step in `getStep.php`. The current step is enough. 4) In `savePayment.php` added a check for the existence of 'savePayment' method before invoking it to avoid possible errors. 5) The fallback to get the first step was also removed in `reload.php`. 6) Removed an unnecessary if condition in `send.php` and directly assigned current step's name to `$current`. 7) In `setQuantity.php`, added a verification to check the existence of 'setQuantity' method before calling it. Related: #172
-
verfasst von Henning Leutz
This commit fixes the errors arising from non-existing classes in the AbstractOrder.php Changes include: - Added a comment on the shipping validation - Corrected type declaration in the reversal function signature to include the possibility of the parameter being null. - Checked for the existence of ShippingStatus and ShippingEntry classes before attempting to get Shipping status and Shipping Ids, respectively. This prevents errors if these classes do not exist. Related: #172
-
verfasst von Henning Leutz
Extended the method existence checks throughout src/QUI/ERP/Order/Basket/ files. Improved the robustness of the code by ensuring that methods such as 'getUuid', 'getProductSetParentUuid', 'getQuantity', 'toArticle', and 'getAttributesForUniqueField' exist before calling them, thus preventing potential undefined method errors. Removed unnecessary comments used for type hinting in favor of functional checks. Related: #172
-
verfasst von Henning Leutz
Changes include: - Updated `AbstractOrderingStep.php` to handle null case in `getOrder` method and modified return type. - Refactored `Order.php` to remove unnecessary checks and improve readability. - Ensured safety against calling non-existent `save()` method in `Checkout.php`. - Simplified address getting logic in `CustomerData.php`. - Removed unnecessary check in isUserB2B function. Related: #172
-
verfasst von Henning Leutz
This commit brings a number of changes across multiple files. The changes include adjustment of variable types, fixing conditions, and the optimization of method calls. 1. In src/QUI/ERP/Order/AbstractOrderProcessProvider.php, the function getDisplay has had its parameters realigned with AbstractOrderingStep, providing a clear type definition. 2. src/QUI/ERP/Order/EventHandling.php has changed the onDetailEquipmentButtons function to expect a ProductTypeInterface, enabling a wider range of object types to be passed in. 3. src/QUI/ERP/Order/Factory.php now only checks for an empty orderId, rather than also improperly comparing to zero. 4. src/QUI/ERP/Order/FrontendUsers/Controls/UserOrders.php, a fallback has been added for when the method getImage does not exist on a Product object. 5. src/QUI/ERP/Order/Mail.php has been updated to use the correct customer address method based on the user's type. 6. Lastly, in src/QUI/ERP/Order/OrderView.php, the getShippingStatus method now correctly specifies null as a possible return type. Related: #172
-
verfasst von Henning Leutz
Changes include: - Modified code formatting to improve readability and conform to best coding practices. - Updated type declarations using pipe (|) operator to indicate variable can hold multiple types. - Adjusted the spacing around the pipe operator in type declarations for improved readability.
-
verfasst von Henning Leutz
This commit fixes several areas: 1. It changes class type in BasketOrder from QUI\\Users\\User to QUI\\Interfaces\\Users\\User. 2. It refactors Order to better handle if statements and moves verification of class existence up to the beginning. Fix involves assuming that function getInvoiceAddress and getDeliveryAddress always return a non-null value. It also updates on how we check class exists for Shipping data. 3. In OrderInProcess, now we check if method 'toArticle' exists on the Product object before calling it and applies similar class checking like in Order for Shipping data. 4. Corrects and standardizes the casing for exception catching in OrderProcess. In summary, these changes lead to a safer and cleaner code base by addressing potential Null Pointer Exceptions and ensuring the existence of classes before they are being called. Related: #172
-
verfasst von Henning Leutz
This commit improves the way processing status id is handled across different methods in the ProcessingStatus module. Now, we consistently cast processing status id as string before passing it to the config setter methods, eliminating any potential issues that might occur due to variable type inconsistencies. Changes are applied to the Factory and Handler classes alike. Related: #172
-
verfasst von Henning Leutz
Updated AbstractOrder.php to return null instead of false in getShippingStatus() when the shipping status is not set. This makes the method's behaviour more consistent. Updated Search.php to add a condition check for class existence before retrieving shipping status. This ensures that the code will not fail if the class is not defined. Modified DataLayer.php to add a condition check for class existence before retrieving shipping. Added @phpstan-ignore-next-line in Utils.php to silence phpstan for the next line of code. Related: #172
-
verfasst von Henning Leutz
-
verfasst von Henning Leutz
Updated the version of `phpstan` from `1.11.8` to `1.*` and set the installed version as `1.12.13` in .phive/phars.xml. This should ensure we're always using the latest version of `phpstan` that matches the specified range.
-
- Feb 22, 2025
-
-
verfasst von Henning Leutz
-
verfasst von Henning Leutz
Updated the `getCustomerFiles` method signature in `AbstractOrder.php` to accept an optional boolean parameter `$parsing`. Method can now be customized to return parsed file information or raw data.
-
- Feb 19, 2025
-
-
verfasst von Patrick Müller
fix: allow new transactions to change the paid_status of an erroneous order See merge request !144
-
verfasst von Patrick Müller
-
- Feb 10, 2025
-
-
verfasst von Henning Leutz
fix: processing content is default-content See merge request !142
-
verfasst von Henning Leutz
-
- Feb 07, 2025
-
-
verfasst von Henning Leutz
fix: handle exception in toOrderInProcess.php See merge request !140
-
verfasst von Henning Leutz
-
verfasst von Henning Leutz
In the ajax/frontend/basket/toOrderInProcess.php: - The QUI\ERP\Order\Factory class was imported. - In the event of an exception, a new order in process is created instead of just logging the error. This change should improve the user experience by preventing any disruption in the order process due to unexpected errors.
-
- Feb 06, 2025
-
-
verfasst von Henning Leutz
fix(Basket): improve basket id handling and user check in Basket.php See merge request !138
-
verfasst von Henning Leutz
Improve readability and interpretability of code by explicitly stating null in union types. This change has been applied across multiple files and functions. PHP8.4 compatibility
-
verfasst von Henning Leutz
Added a conditional check in src/QUI/ERP/Order/Basket/Basket.php to convert basketId to actual id from user's session if it is a boolean value. This fixes potential issues that may arise with non-integer basketIds. Also, introduced a safeguard check before saving to ensure there is a valid User. If not, the save function is exited early to prevent potential errors or undesired actions.
-
- Feb 04, 2025
-
-
verfasst von Henning Leutz
fix: update default paymentId status See merge request !137
-
verfasst von Henning Leutz
Changed the default value of paymentId status in the paymentChangeable list from 1 to 0 to ensure accurate payment status representation. Related: #176
-
verfasst von Henning Leutz
-
- Jan 20, 2025
-
-
verfasst von Michael Danielczok
-