Skip to content
Code-Schnipsel Gruppen Projekte
Commit f11a7d4b erstellt von Henning Leutz's avatar Henning Leutz :martial_arts_uniform:
Dateien durchsuchen

refactor(phpunit): ensure consistent handling of processing status id

This commit improves the way processing status id is handled across different methods in the
ProcessingStatus module. Now, we consistently cast processing status id as string before passing it
to the config setter methods, eliminating any potential issues that might occur due to variable
type inconsistencies. Changes are applied to the Factory and Handler classes alike.

Related: #172
Übergeordneter a5f3b8e5
No related branches found
No related tags found
2 Merge Requests!146fix: update `getCustomerFiles` method signature in `AbstractOrder`,!145Update 'next-3.x' with latest changes from 'main'
Pipeline #15526 fehlgeschlagen mit Phase
in 2 Minuten und 36 Sekunden
......@@ -31,7 +31,7 @@ class Factory extends QUI\Utils\Singleton
* @throws QUI\Exception
* @todo permissions
*/
public function createProcessingStatus(int|string $id, string $color, array $title): void
public function createProcessingStatus(int | string $id, string $color, array $title): void
{
$list = Handler::getInstance()->getList();
$id = (int)$id;
......@@ -48,7 +48,7 @@ public function createProcessingStatus(int|string $id, string $color, array $tit
$Package = QUI::getPackage('quiqqer/order');
$Config = $Package->getConfig();
$Config->setValue('processing_status', $id, $color);
$Config->setValue('processing_status', (string)$id, $color);
$Config->save();
// translations
......
......@@ -149,7 +149,7 @@ public function deleteProcessingStatus(int | string $id): void
QUI\Translator::publish('quiqqer/order');
// update config
$this->OrderConfig->del('processing_status', $Status->getId());
$this->OrderConfig->del('processing_status', (string)$Status->getId());
$this->OrderConfig->save();
}
......@@ -168,7 +168,7 @@ public function setProcessingStatusNotification(int $id, bool $notify): void
$Status = $this->getProcessingStatus($id);
// update config
$this->OrderConfig->setValue('processing_status_notification', $Status->getId(), $notify ? "1" : "0");
$this->OrderConfig->setValue('processing_status_notification', (string)$Status->getId(), $notify ? "1" : "0");
$this->OrderConfig->save();
}
......@@ -213,7 +213,7 @@ public function updateProcessingStatus(int | string $id, int | string $color, ar
QUI\Translator::publish('quiqqer/order');
// update config
$this->OrderConfig->setValue('processing_status', $Status->getId(), $color);
$this->OrderConfig->setValue('processing_status', (string)$Status->getId(), $color);
$this->OrderConfig->save();
}
......
0% oder .
You are about to add 0 people to the discussion. Proceed with caution.
Bearbeitung dieser Nachricht zuerst beenden!
Bitte registrieren oder zum Kommentieren