Skip to content
Code-Schnipsel Gruppen Projekte
  1. Mär 04, 2025
    • Patrick Müller's avatar
      fix: do not use non-existing method · 462c4742
      verfasst von Patrick Müller
      462c4742
    • Henning Leutz's avatar
      refactor(phpcs): improve code readability in `MembershipUser.php` · e64d3393
      verfasst von Henning Leutz
      This commit refactors `MembershipUser.php` to improve code readability. It does this by including
      spaces around the concatenation operators for better visual separation. This makes the identifiers
      for verification checks much more readable.
      e64d3393
    • Henning Leutz's avatar
      fix(phpstan): clean up and simplify code across multiple files · 6d552ca5
      verfasst von Henning Leutz
      The membership-related code was cleaned up across `getList.php`, `Handler.php`, `Membership.php`,
      `Users/Handler.php`, and `Users/MembershipUser.php` files. Removed unnecessary comments and
      @phpstan-ignore lines. Added strict type checking where it was missing and restructured some
      conditions for better readability. Also, simplified the return statements in some methods.
      6d552ca5
    • Patrick Müller's avatar
      fix: phpstan errors · 68765f13
      verfasst von Patrick Müller
      68765f13
    • Henning Leutz's avatar
      refactor(phpstan): improve type definitions and error handling · 09bc150f
      verfasst von Henning Leutz
      This commit refactors several areas of the code to improve type definitions and error handling.
      Main changes include:
      - Improved the type definitions for function arguments and return types within the Handler,
      Membership and Users Handler classes.
      - Added error handling for instances where the Membership is not an instance of
      QUI\Memberships\Membership.
      - Updated the commenting style to more clearly define variables.
      - Changed the use of \PDO to PDO for cleaner code.
      - Removed unnecessary conditionals in the WHERE clause building of an SQL query, leading to
      cleaner, more straightforward code.
      09bc150f
    • Henning Leutz's avatar
      fix(phpstan): improve code flexibility and robustness · 76427fe2
      verfasst von Henning Leutz
      - Removed redundant docblock.
      - Added instance check for `$User` before attempting to remove it from groups to prevent potential
      errors.
      - Ensured `hasMembershipUserId` method exists before calling it to prevent undefined method errors.
      - Adjusted `addHistoryEntry` function to receive a string as the second parameter instead of an
      array.
      - Removed redundant array-to-string conversion in `addHistoryEntry` function.
      - Ignored `phpstan` warning regarding method's return type.
      76427fe2
    • Henning Leutz's avatar
      fix(phpstan): improve return types and exception handling in memberships · 8aa6d8de
      verfasst von Henning Leutz
      This commit addresses three major updates in our Memberships module:
      
      1. In Handler.php, we clarified the return type of `isLinkedToContracts()` method by explicitly
      defining it as boolean.
      2. In AbstractMembershipUserLinkVerificationHandler.php, we simplified the Exception import and
      updated the type in the `getMembershipUser()` method's doc comment.
      3. In MembershipUser.php, the constructors for `CancelVerification` and `AbortCancelVerification`
      are now called without the user id.
      
      These changes enhance code readability and maintainability while ensuring safer calls.
      8aa6d8de
    • Henning Leutz's avatar
      fix: improve type consistency and readability in memberships · 0978b32e
      verfasst von Henning Leutz
      This commit improves the type consistency and readability of the code in the Membership class and
      related classes. The changes include adding strict types, removing unused imports, using type
      hinting, and replacing old switch-case syntax with match expressions.
      
      Specifically, it changes the signature of several functions, adds and removes some class imports,
      and replaces old style function syntax with modern type hinting for better readability and
      maintainability. Moreover, it adds PHP built-in functions instead of using their fully qualified
      form. It also improves readability by replacing the switch-case syntax with the new and more
      convenient match expression when parsing intervals from the duration.
      0978b32e
    • Henning Leutz's avatar
      9bb21fd6
  2. Jan 08, 2025
  3. Jan 03, 2025
  4. Okt 23, 2024
  5. Okt 17, 2024
  6. Sep 24, 2024
  7. Jan 22, 2024
  8. Jan 03, 2024
  9. Jan 17, 2023
  10. Aug 23, 2022
  11. Sep 24, 2021
  12. Jan 11, 2021
  13. Dez 10, 2020
  14. Nov 16, 2020
  15. Aug 07, 2020
  16. Mai 08, 2020
  17. Mai 05, 2020
  18. Mär 26, 2020
  19. Mär 10, 2020
  20. Mär 09, 2020
  21. Feb 04, 2020
  22. Dez 10, 2019
  23. Nov 13, 2019