fix: do not extend membership by itself if linked with a contract

src/QUI/Memberships/Cron.php

@@ -30,6 +30,7 @@ public static function checkMembershipUsers()
         $now                            = time();
         $cancelConfirmReminderAfterDays = (int)MembershipUsersHandler::getSetting('cancelReminderDays');
         $Now                            = date_create();
+        $isLinkedToContracts            = Handler::isLinkedToContracts();
 
         foreach ($result as $row) {
             try {
@@ -94,8 +95,11 @@ public static function checkMembershipUsers()
                 }
 
                 // extend if membership is extended automatically
-                if ($Membership->isAutoExtend() && !$MembershipUser->getContractId()) {
-                    $MembershipUser->extend();
+                if ($Membership->isAutoExtend()) {
+                    // Only extend if not extended by contract
+                    if (!$isLinkedToContracts || !$MembershipUser->getContractId()) {
+                        $MembershipUser->extend();
+                    }
                     continue;
                 }
 

src/QUI/Memberships/Handler.php

@@ -427,4 +427,25 @@ public static function getDefaultMembership()
 
         return self::getInstance()->getChild((int)$membershipId);
     }
+
+    /**
+     * Check if memberships are linked to contracts
+     *
+     * @return bool
+     */
+    public static function isLinkedToContracts()
+    {
+        try {
+            $Conf = QUI::getPackage('quiqqer/memberships')->getConfig();
+
+            if ((int)$Conf->get('membershipusers', 'linkWithContracts')) {
+                return true;
+            }
+        } catch (\Exception $Exception) {
+            QUI\System\Log::writeException($Exception);
+            return false;
+        }
+
+        return false;
+    }
 }