Skip to content
Code-Schnipsel Gruppen Projekte
Commit 04bf0dc4 erstellt von Henning Leutz's avatar Henning Leutz :martial_arts_uniform:
Dateien durchsuchen

fix: correct phpstan errors and update schema urls

This commit includes several modifications:
- Removed the ignoreErrors directives in phpstan-baseline.neon as the corresponding issues have
been resolved
- Updated 'itemtype' URL from 'http://' to 'https://'
- Removed an obsolete comment block above the getSite method in Timeline.php
- Added variable documentation in types/timeline.php to clarify variable types and avoid phpstan
errors.

Related: #3
Übergeordneter 2b6b4662
Keine zugehörigen Branchen gefunden
Keine zugehörigen Tags gefunden
2 Merge Requests!10fix: correct phpstan errors and update schema urls,!8Update 'next-3.x' with latest changes from 'main'
Pipeline-Nr. 15145 mit Warnungen bestanden
parameters: parameters:
ignoreErrors: ignoreErrors:
- \ No newline at end of file
message: "#^Parameter \\#2 \\$val of method QUI\\\\QDOM\\:\\:setAttribute\\(\\) expects array\\|bool\\|object\\|string, int given\\.$#"
count: 1
path: src/QUI/Timeline/Bricks/Timeline.php
-
message: "#^Variable \\$Engine might not be defined\\.$#"
count: 1
path: types/timeline.php
-
message: "#^Variable \\$Site might not be defined\\.$#"
count: 4
path: types/timeline.php
...@@ -38,7 +38,7 @@ public function __construct(array $attributes = []) ...@@ -38,7 +38,7 @@ public function __construct(array $attributes = [])
'displayTemplate' => false, 'displayTemplate' => false,
// Custom children template css (path to css file); overwrites "display" // Custom children template css (path to css file); overwrites "display"
'displayCss' => false, 'displayCss' => false,
'itemtype' => 'http://schema.org/ItemList', 'itemtype' => 'https://schema.org/ItemList',
'child-itemtype' => 'https://schema.org/ListItem', 'child-itemtype' => 'https://schema.org/ListItem',
'child-itemprop' => 'itemListElement' 'child-itemprop' => 'itemListElement'
]); ]);
...@@ -126,11 +126,6 @@ public function getBody(): string ...@@ -126,11 +126,6 @@ public function getBody(): string
return $Engine->fetch($templateFile); return $Engine->fetch($templateFile);
} }
/**
* @return null|QUI\Projects\Site
* @throws Exception
*/
protected function getSite(): ?QUI\Interfaces\Projects\Site protected function getSite(): ?QUI\Interfaces\Projects\Site
{ {
if ($this->getAttribute('Site')) { if ($this->getAttribute('Site')) {
......
...@@ -2,6 +2,11 @@ ...@@ -2,6 +2,11 @@
/** /**
* Site list * Site list
*
* @var QUI\Projects\Project $Project
* @var QUI\Projects\Site $Site
* @var QUI\Interfaces\Template\EngineInterface $Engine
* @var QUI\Template $Template
*/ */
$Timeline = new QUI\Timeline\Controls\Timeline([ $Timeline = new QUI\Timeline\Controls\Timeline([
......
0% Lade oder .
You are about to add 0 people to the discussion. Proceed with caution.
Bearbeitung dieser Nachricht zuerst beenden!
Bitte registrieren oder zum Kommentieren