Skip to content
Code-Schnipsel Gruppen Projekte
  1. Feb 25, 2025
    • Henning Leutz's avatar
      Merge branch 'next-2.x' into 'main' · c805f1dd
      verfasst von Henning Leutz
      fix(phpstan): allow null as parameter in various functions
      
      See merge request !45
      2.0.10
      c805f1dd
    • Henning Leutz's avatar
      chore(phpstan): update erroneous return type message in phpstan-baseline · ab8fc62b
      verfasst von Henning Leutz
      This commit changes the incorrect return type message found in the phpstan-baseline.neon file.
      Return type of method ShippingTimePeriod::getFrontendView() has been correctly aligned to match
      that of TimePeriod::getFrontendView(). This ensures clear and accurate type error messages that
      adhere to the standard format.
      ab8fc62b
    • Henning Leutz's avatar
      chore(phpstan): error message compatibility for getFrontendView method · b5ad037d
      verfasst von Henning Leutz
      Updated the error message in the phpstan-baseline to reflect the compatibility between the
      getFrontendView methods in ShippingTimePeriod and TimePeriod classes.
      b5ad037d
    • Henning Leutz's avatar
      fix: resolve erroneous types and classes in phpstan baseline · 7da729e9
      verfasst von Henning Leutz
      This commit resolves multiple issues identified by the phpstan static analysis tool. The erroneous
      types and classes in `AbstractShippingEntry.php`, `EventHandler.php`, `ShippingTimePeriod.php` have
      been refractored to match the correct class and method signatures. The erroneous sections have been
      updated with the appropriate classes and methods for QUI\\\\ERP\\\\Accounting\\\\Invoice,
      QUI\\\\ERP\\\\Accounting\\\\Offers, and QUI\\\\ERP\\\\SalesOrders.
      
      Related: #55
      7da729e9
    • Henning Leutz's avatar
      refactor(phpcs): improve readability in getShippingPriceFactor method · c87fe722
      verfasst von Henning Leutz
      This commit refactors the getShippingPriceFactor method in the Shipping.php file, by adding a line
      break for the method's parameter for better visibility and readability.
      c87fe722
    • Henning Leutz's avatar
      refactor(phpstan): enhance type enforcement and error handling in shipping rules · c79bc5df
      verfasst von Henning Leutz
      This commit enhances the type enforcement in the Shipping module by explicitly checking for method
      existence before calls on variable types. In addition, it enforces argument type checks for several
      function and method declarations to avoid type-related errors. Moreover, the error handling in
      different functions has been improved by catching potential exceptions and logging them for debug
      purposes. The commit also optimizes a PHP sorting function by leveraging the spaceship operator
      instead of using conventional comparisons.
      
      Related: #55
      c79bc5df
    • Henning Leutz's avatar
      fix(phpstan): improve type handling and method returns · e5ed940a
      verfasst von Henning Leutz
      This commit includes several changes to improve type handling and the returns of various methods.
      It includes changes in files related to Shipping rules and status, as well as tracking. Notable
      changes include:
      
      - Refactoring of method signatures and corresponding usages to use type hinting for better error
      handling.
      - Fixed return types in Factory.php to return more specific types (ShippingRule and ShippingEntry).
      - Adjusted the createShippingStatus method to convert `id` to string before passing it to setValue
      method in Config.
      - Fixed active carrier filtering in Tracking for boolean conversion.
      - Modified handling and events related to shipping in ShippingEntry.php and Factory.php.
      - Other minor cleanups and refactorings.
      
      Related: #55
      e5ed940a
    • Henning Leutz's avatar
      fix(phpstan): adjust method argument typings for better code readability · ac6dda13
      verfasst von Henning Leutz
      Updated method argument typings from `Type $var = null` to `null | Type $var = null` across
      multiple files to improve readability and understanding of the code. This change aligns with modern
      coding standards and the principle of explicit over implicit.
      Affected files:
      - `AbstractShippingEntry.php`
      - `AbstractShippingType.php`
      - `ShippingInterface.php`
      - `ShippingTypeInterface.php`
      - `Factory.php`
      - `ShippingRule.php`
      - `Shipping.php`
      
      PHP9 + PHP8.3 null deprecated
      ac6dda13
    • Henning Leutz's avatar
      fix(phpstan): allow null as parameter in various functions · 8490a644
      verfasst von Henning Leutz
      This commit does the following changes:
      
      1. Updated the PHPStan version from 1.11.8 to 1.12.13 in phars.xml
      2. In various classes, added the possibility to pass `null` as a parameter to a number of
      functions. Affected classes include but are not limited to: `ShippingInterface`, `Handler`,
      `Status`, `StatusUnknown`, and `ShippingEntry`.
      3. Updated return types in the `ShippingEntry` class to include `null` option.
      4. Simplified return types in various places from `datatype|datatype|null` to possibly nullable
      `datatype`.
      
      PHP9 + PHP8.4 null deprecated
      8490a644
  2. Nov 28, 2024
  3. Sep 09, 2024
  4. Aug 05, 2024
  5. Aug 01, 2024
  6. Jul 30, 2024
  7. Jul 22, 2024
  8. Jul 18, 2024
  9. Jun 20, 2024
  10. Jun 19, 2024
  11. Jun 14, 2024
  12. Mai 08, 2024