chore: update phpstan version and remove phpstan-baseline (!36) · Merge Requests · QUIQQER / Menu

Zusammengeführt Henning Leutz schlägt vor 3 Wochen vor, next-3.x in main zu mergen.

Mär 04, 2025

fix(phpstan): enhance code readability and adopt safer practices · 78d9b1e2

verfasst von Henning Leutz vor 3 Wochen

Several changes have been made across multiple files to enhance code readability and follow safer
coding practices.

1. Breakdown of long lines of attributes/code into multiple lines with added comments for better
readability. This was done in Submenu.php

2. Replaced '==' operation with 'empty()' function to check for empty strings in Submenu.php

3. Safer checking of if method 'getCachePath' exists on 'getSite' to avoid potential errors &
Ensure the last insert ID is always an integer in the database PDO in DropDownMenu.php and
Factory.php

4. Refactor conditions for more clear type hinting in multiple files; including
Independent/Handler.php, Independent/Items/AbstractMenuItem.php, Independent/Items/Site.php,
Independent/Menu.php, MegaMenu.php, and NavTabs.php

The concept of safe concatenation or use of '|null|' has been introduced where needed across many
files.

Related: #38

78d9b1e2

chore: update phpstan version and remove phpstan-baseline · 6f309bd3

verfasst von Henning Leutz vor 3 Wochen

This commit updates the version of phpstan specified in .phive/phars.xml file to 1.* and the
current installed version to 1.12.13.

Additionally, it removes all the previously ignored errors in phpstan-baseline.neon. The actions
were taken possibly due to fixes to these errors or related update in the codebase causing them to
be obsolete.

Please ensure related checks/errors do not surface again due to the removed baseline ignores.

6f309bd3

chore: update phpstan version and remove phpstan-baseline

Merge Request-Berichte

Aktivität