Merge branch 'dev' into 'next'

fix: use global process not for itself

See merge request !29

src/QUI/ERP/Accounting/Invoice/Factory.php

@@ -22,22 +22,20 @@ class Factory extends QUI\Utils\Singleton
      * Creates a new temporary invoice
      *
      * @param QUI\Interfaces\Users\User|null $User
-     * @param string|bool $hash - hash of the process
+     * @param bool|string $globalProcessId - hash of the process
      * @return InvoiceTemporary
      * @throws
      */
-    public function createInvoice($User = null, $hash = false): InvoiceTemporary
-    {
+    public function createInvoice(
+        QUI\Interfaces\Users\User $User = null,
+        bool|string $globalProcessId = false
+    ): InvoiceTemporary {
         if ($User === null) {
             $User = QUI::getUserBySession();
         }
 
-        if ($hash === false) {
-            $hash = QUI\Utils\Uuid::get();
-        }
-
-        $processId = $hash;
 
+        $hash = QUI\Utils\Uuid::get();
 
         // check if hash already exists, if hash exists, we cant use it twice
         try {
@@ -46,7 +44,7 @@ public function createInvoice($User = null, $hash = false): InvoiceTemporary
             // if invoice hash exist, we need a new hash
             $hash = QUI\Utils\Uuid::get();
         } catch (QUI\Exception $Exception) {
-            QUI\System\Log::writeDebugException($Exception);
+            // nothing
         }
 
 
@@ -68,7 +66,7 @@ public function createInvoice($User = null, $hash = false): InvoiceTemporary
                 'editor_id' => $editor,
                 'editor_name' => '-',
                 'hash' => $hash,
-                'global_process_id' => $processId,
+                'global_process_id' => $globalProcessId,
                 'customer_id' => 0,
                 'type' => Handler::TYPE_INVOICE_TEMPORARY,
                 'paid_status' => QUI\ERP\Constants::PAYMENT_STATUS_OPEN,

src/QUI/ERP/Accounting/Invoice/Invoice.php

@@ -728,15 +728,17 @@ public function storno(string $reason, $PermissionUser = null): int
      * Copy the invoice to a temporary invoice
      *
      * @param null|QUI\Interfaces\Users\User $PermissionUser
-     * @param false|string $globalProcessId
+     * @param bool|string $globalProcessId
      * @return InvoiceTemporary
      *
      * @throws Exception
      * @throws QUI\Exception
      * @throws QUI\Permissions\Exception
      */
-    public function copy($PermissionUser = null, $globalProcessId = false): InvoiceTemporary
-    {
+    public function copy(
+        QUI\Interfaces\Users\User $PermissionUser = null,
+        bool|string $globalProcessId = false
+    ): InvoiceTemporary {
         if ($PermissionUser === null) {
             $PermissionUser = QUI::getUserBySession();
         }

src/QUI/ERP/Accounting/Invoice/InvoiceTemporary.php

@@ -1096,7 +1096,7 @@ public function copy($PermissionUser = null): InvoiceTemporary
 
         $Handler = Handler::getInstance();
         $Factory = Factory::getInstance();
-        $New = $Factory->createInvoice($PermissionUser);
+        $New = $Factory->createInvoice($PermissionUser, $this->getGlobalProcessId());
 
         $currentData = QUI::getDataBase()->fetch([
             'from' => $Handler->temporaryInvoiceTable(),
@@ -1140,7 +1140,7 @@ public function copy($PermissionUser = null): InvoiceTemporary
      * @throws QUI\Permissions\Exception
      * @throws QUI\Exception
      */
-    public function post($PermissionUser = null): Invoice
+    public function post(QUI\Interfaces\Users\User $PermissionUser = null): Invoice
     {
         if ($PermissionUser === null) {
             $PermissionUser = QUI::getUserBySession();