Skip to content
Code-Schnipsel Gruppen Projekte

fix(phpstan): improved method validity checks and reduced error handling

Zusammengeführt fix(phpstan): improved method validity checks and reduced error handling
next-2.x nach main
Zusammengeführt Henning Leutz schlägt vor, next-2.x in main zu mergen.
  1. Feb 14, 2025
    • Henning Leutz's avatar
      refactor(phpstan): change order interface to erp entity interface in Discount · e8c4d77c
      verfasst von Henning Leutz 
      Updated the 'canUsedInOrder' function in Discount.php to accept ERP Entity Interface arguments
instead of Order Interfaces for better flexibility and compatibility. Added checks to ensure that
the provided entity is an instance of the Order Interface, increasing robustness.
      e8c4d77c
    • Henning Leutz's avatar
      fix(phpstan): improved method validity checks and reduced error handling · 6100708f
      verfasst von Henning Leutz 
      This commit fixes several issues in different PHP files.
- Added `method_exists` checks for `isActive` method in `activate.php`, `deactivate.php` and
`toggle.php` to prevent calls to an undefined method.
- Similar check added for `getTitle` method in `get.php`.
- Fixed sorting functionality in `search.php` by using `strcmp` instead of greater than comparison.
- Removed a large number of ignored errors in `phpstan-baseline.neon`, indicating reduced error
handling.
- Corrected the `implode` parameters order in `Discount.php` and typecasted variable to string
before using `explode` in `PriceFactor.php`.
- Updated `getTitle` & `toPriceFactor` method parameters in `Discount.php` to use union types for
compatibility with different data types.

Related: #18
      6100708f
  3. Aug 05, 2024
  5. Aug 02, 2024

PCSG & QUIQQER support and DEV System - GitLab