Skip to content
Code-Schnipsel Gruppen Projekte
Commit 6100708f erstellt von Henning Leutz's avatar Henning Leutz :martial_arts_uniform:
Dateien durchsuchen

fix(phpstan): improved method validity checks and reduced error handling

This commit fixes several issues in different PHP files.
- Added `method_exists` checks for `isActive` method in `activate.php`, `deactivate.php` and
`toggle.php` to prevent calls to an undefined method.
- Similar check added for `getTitle` method in `get.php`.
- Fixed sorting functionality in `search.php` by using `strcmp` instead of greater than comparison.
- Removed a large number of ignored errors in `phpstan-baseline.neon`, indicating reduced error
handling.
- Corrected the `implode` parameters order in `Discount.php` and typecasted variable to string
before using `explode` in `PriceFactor.php`.
- Updated `getTitle` & `toPriceFactor` method parameters in `Discount.php` to use union types for
compatibility with different data types.

Related: #18
Übergeordneter 000c2bb1
No related branches found
No related tags found
2 Merge Requests!13Update 'next-3.x' with latest changes from 'main',!12fix(phpstan): improved method validity checks and reduced error handling
Pipeline #15001 mit Warnungen bestanden mit Phase
in 2 Minuten und 15 Sekunden
Status
Pipeline
Erstellt von
Phasen
Aktionen
Warnung

00:02:15

avatar

Keine Artefakte gefunden