fix(phpstan): code improvements and resolve warnings (!18) · Merge Requests · QUIQQER / coupons

Zusammengeführt Henning Leutz schlägt vor 3 Wochen vor, next-2.x in main zu mergen.

Feb 27, 2025

fix: remove phpstan from gitlab CI pipeline · 2b857d4f

verfasst von Henning Leutz vor 3 Wochen

The `.gitlab-ci.yml` file was updated to remove the `phpstan` job. This change means we will no
longer run static analysis automatically on our CI pipeline. Further discussions may be needed on
whether to replace this with another tool or integrate it differently.

2b857d4f

refactor: var to const refactor · 6b1d6f44
verfasst von Henning Leutz vor 3 Wochen

6b1d6f44

refactor: use const instead of var in CouponCodeInput.js · 0619681d

verfasst von Henning Leutz vor 3 Wochen

Modified 'var' declarations to 'const' in CouponCodeInput.js file for better ES6 compliance. This
refactoring helps increase code readability and ensures variables are block-scoped, reducing the
risk of accidental variable reassignment or mutation.

0619681d

Feb 23, 2025

chore(phpstan): update gitlab-ci configuration · 782f0cd0
verfasst von Henning Leutz vor 3 Wochen
```
Debug test
```
782f0cd0

chore: phpstan modify · 0c2d3abe

verfasst von Henning Leutz vor 3 Wochen

In this commit, modifications have been made to the .gitlab-ci.yml file to allow running PHPUnit on
PHP 8.3 in our pipeline. A new job `modify-job` was added which runs phpstan script with following
instructions:

- Keeping other autoloaders with `QUIQQER_OTHER_AUTOLOADERS=KEEP`
- Disabling progress display with `--no-progress`
- Removing memory limit with `--memory-limit=-1`
- Enabling debug mode with `--debug`

0c2d3abe

Feb 22, 2025

chore: update phpstan configuration file · 2ab12e56

verfasst von Henning Leutz vor 3 Wochen

The commit modifies the phpstan.dist.neon configuration file. The changes include removing the
excludePaths section and adjusting the end of the file to not have a new line. This simplification
will better suit our testing environment.

2ab12e56

fix: update phpstan config and add condition to package setup in src/QUI/ERP/Coupons/Events.php · 749db82c

verfasst von Henning Leutz vor 3 Wochen

This commit includes a minor modification in the `phpstan.dist.neon` file where the `excludePaths`
value has been updated. Besides, a conditional check has been added in the `onPackageSetup`
function, under `Events.php` in the `src/QUI/ERP/Coupons` directory, to only proceed if the package
name is 'quiqqer/coupons'. This additional check generally improves the efficiency and correctness
of the package setup process.

749db82c

chore(phpstan): exclude problematic file from phpstan analysis · 7e2e2aea

verfasst von Henning Leutz vor 3 Wochen

This commit modifies the phpstan.dist.neon to exclude the DigitalCouponProductType.php file from
being analyzed by PHPStan. This was necessary due to consistent unresolvable errors.

7e2e2aea

refactor(phpstand): update coupon code and physical coupon product · 6ca95f6b

verfasst von Henning Leutz vor 3 Wochen

This commit modifies the `src/QUI/ERP/Coupons/CouponCode.php` by removing an unexplained variable
annotation.
In `src/QUI/ERP/Coupons/Products/PhysicalCouponProductType.php`, it introduces an import statement
for `QUI\\Locale` and updated the `Locale` parameter type definition in `getTypeDescription`
function. This change improves code readability and consistency.

6ca95f6b

fix(phpstan): code improvements and resolve warnings · 2833ed98

verfasst von Henning Leutz vor 3 Wochen

Reviewed code and made several improvements which provide better error handling, code quality, and
resolved warnings. The changes include:
- Syntax modifications for better readability,
- Ensured variable type checks before using methods,
- Resolved warning instances in phpstan,
- Adapted code to comply with modern PHP nullable type indicator.

Alongside, made version update in phive/phars.xml. Also, unnecessary comments or instances are
removed for a cleaner code.

Related: #16

2833ed98

fix(phpstan): code improvements and resolve warnings

Merge Request-Berichte

Aktivität