Skip to content
Code-Schnipsel Gruppen Projekte
Commit 6b1d6f44 erstellt von Henning Leutz's avatar Henning Leutz :martial_arts_uniform:
Dateien durchsuchen

refactor: var to const refactor

Übergeordneter 0619681d
No related branches found
No related tags found
2 Merge Requests!19Update 'next-3.x' with latest changes from 'main',!18fix(phpstan): code improvements and resolve warnings
Pipeline #15707 mit Warnungen bestanden mit Phase
Phase:
    in 27 Sekunden
    Dieser Commit ist Teil des Merge Request !18. Hier erstellte Kommentare werden im Kontext dieses Merge Request erstellt.
    Alle erweitern Leerzeichenänderungen ausblenden
    Inline Nebeneinander
    bin/backend/classes/CouponCodes.js
    + 13
    − 13
    Bearbeiten Zeige Datei @ 6b1d6f44
    ...@@ -13,7 +13,7 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [ ...@@ -13,7 +13,7 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [
    ], function (QUIAjax) { ], function (QUIAjax) {
    "use strict"; "use strict";
    var pkg = 'quiqqer/coupons'; const pkg = 'quiqqer/coupons';
    return new Class({ return new Class({
    ...@@ -28,9 +28,9 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [ ...@@ -28,9 +28,9 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [
    create: function (Attributes) { create: function (Attributes) {
    return new Promise(function (resolve, reject) { return new Promise(function (resolve, reject) {
    QUIAjax.post('package_quiqqer_coupons_ajax_create', resolve, { QUIAjax.post('package_quiqqer_coupons_ajax_create', resolve, {
    'package' : pkg, 'package': pkg,
    attributes: JSON.encode(Attributes), attributes: JSON.encode(Attributes),
    onError : reject onError: reject
    }); });
    }); });
    }, },
    ...@@ -45,10 +45,10 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [ ...@@ -45,10 +45,10 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [
    edit: function (id, Attributes) { edit: function (id, Attributes) {
    return new Promise(function (resolve, reject) { return new Promise(function (resolve, reject) {
    QUIAjax.post('package_quiqqer_coupons_ajax_edit', resolve, { QUIAjax.post('package_quiqqer_coupons_ajax_edit', resolve, {
    'package' : pkg, 'package': pkg,
    id : id, id: id,
    attributes: JSON.encode(Attributes), attributes: JSON.encode(Attributes),
    onError : reject onError: reject
    }); });
    }); });
    }, },
    ...@@ -63,8 +63,8 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [ ...@@ -63,8 +63,8 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [
    return new Promise(function (resolve, reject) { return new Promise(function (resolve, reject) {
    QUIAjax.post('package_quiqqer_coupons_ajax_delete', resolve, { QUIAjax.post('package_quiqqer_coupons_ajax_delete', resolve, {
    'package': pkg, 'package': pkg,
    ids : JSON.encode(ids), ids: JSON.encode(ids),
    onError : reject onError: reject
    }); });
    }); });
    }, },
    ...@@ -78,9 +78,9 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [ ...@@ -78,9 +78,9 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [
    getList: function (SearchParams) { getList: function (SearchParams) {
    return new Promise(function (resolve, reject) { return new Promise(function (resolve, reject) {
    QUIAjax.get('package_quiqqer_coupons_ajax_getList', resolve, { QUIAjax.get('package_quiqqer_coupons_ajax_getList', resolve, {
    'package' : pkg, 'package': pkg,
    searchParams: JSON.encode(SearchParams), searchParams: JSON.encode(SearchParams),
    onError : reject onError: reject
    }); });
    }); });
    }, },
    ...@@ -96,9 +96,9 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [ ...@@ -96,9 +96,9 @@ define('package/quiqqer/coupons/bin/backend/classes/CouponCodes', [
    return new Promise(function (resolve, reject) { return new Promise(function (resolve, reject) {
    QUIAjax.post('package_quiqqer_coupons_ajax_sendMail', resolve, { QUIAjax.post('package_quiqqer_coupons_ajax_sendMail', resolve, {
    'package': pkg, 'package': pkg,
    ids : JSON.encode(ids), ids: JSON.encode(ids),
    resend : resend ? 1 : 0, resend: resend ? 1 : 0,
    onError : reject onError: reject
    }); });
    }); });
    } }
    ......
    bin/backend/controls/Manager.js
    + 125
    − 125
    Bearbeiten Zeige Datei @ 6b1d6f44
    Dieser Diff ist reduziert.
    bin/backend/controls/Window.js
    + 34
    − 34
    Bearbeiten Zeige Datei @ 6b1d6f44
    ...@@ -18,7 +18,7 @@ define('package/quiqqer/coupons/bin/backend/controls/Window', [ ...@@ -18,7 +18,7 @@ define('package/quiqqer/coupons/bin/backend/controls/Window', [
    return new Class({ return new Class({
    Extends: QUIConfirm, Extends: QUIConfirm,
    Type : 'package/quiqqer/coupons/bin/backend/controls/Window', Type: 'package/quiqqer/coupons/bin/backend/controls/Window',
    Binds: [ Binds: [
    '$listRefresh', '$listRefresh',
    ...@@ -30,14 +30,14 @@ define('package/quiqqer/coupons/bin/backend/controls/Window', [ ...@@ -30,14 +30,14 @@ define('package/quiqqer/coupons/bin/backend/controls/Window', [
    this.parent(options); this.parent(options);
    this.setAttributes({ this.setAttributes({
    icon : 'fa fa-credit-card-alt', icon: 'fa fa-credit-card-alt',
    title : QUILocale.get(lg, 'controls.manager.title'), title: QUILocale.get(lg, 'controls.manager.title'),
    maxHeight: 600, maxHeight: 600,
    maxWidth : 500, maxWidth: 500,
    }); });
    this.addEvents({ this.addEvents({
    onOpen : this.$onOpen, onOpen: this.$onOpen,
    onResize: this.$onResize onResize: this.$onResize
    }); });
    }, },
    ...@@ -64,54 +64,54 @@ define('package/quiqqer/coupons/bin/backend/controls/Window', [ ...@@ -64,54 +64,54 @@ define('package/quiqqer/coupons/bin/backend/controls/Window', [
    const Container = new Element('div').inject(this.getContent()); const Container = new Element('div').inject(this.getContent());
    this.$Grid = new Grid(Container, { this.$Grid = new Grid(Container, {
    columnModel : [ columnModel: [
    { {
    header : QUILocale.get('quiqqer/system', 'id'), header: QUILocale.get('quiqqer/system', 'id'),
    dataIndex: 'id', dataIndex: 'id',
    dataType : 'number', dataType: 'number',
    width : 50 width: 50
    }, },
    { {
    header : QUILocale.get(lg, 'controls.manager.tbl.header.code'), header: QUILocale.get(lg, 'controls.manager.tbl.header.code'),
    dataIndex: 'code', dataIndex: 'code',
    dataType : 'string', dataType: 'string',
    width : 150 width: 150
    }, },
    { {
    header : QUILocale.get(lg, 'controls.manager.tbl.header.title'), header: QUILocale.get(lg, 'controls.manager.tbl.header.title'),
    dataIndex: 'title', dataIndex: 'title',
    dataType : 'string', dataType: 'string',
    width : 200 width: 200
    }, },
    { {
    header : QUILocale.get(lg, 'controls.manager.tbl.header.status'), header: QUILocale.get(lg, 'controls.manager.tbl.header.status'),
    dataIndex: 'status', dataIndex: 'status',
    dataType : 'node', dataType: 'node',
    width : 200, width: 200,
    className: 'clickable' className: 'clickable'
    }, },
    { {
    header : QUILocale.get(lg, 'controls.manager.tbl.header.validUntilDate'), header: QUILocale.get(lg, 'controls.manager.tbl.header.validUntilDate'),
    dataIndex: 'validUntilDateText', dataIndex: 'validUntilDateText',
    dataType : 'string', dataType: 'string',
    width : 150 width: 150
    }, },
    { {
    header : QUILocale.get(lg, 'controls.manager.tbl.header.reusable'), header: QUILocale.get(lg, 'controls.manager.tbl.header.reusable'),
    dataIndex: 'maxUsageLabel', dataIndex: 'maxUsageLabel',
    dataType : 'string', dataType: 'string',
    width : 150 width: 150
    }, },
    { {
    header : QUILocale.get(lg, 'controls.manager.tbl.header.createDate'), header: QUILocale.get(lg, 'controls.manager.tbl.header.createDate'),
    dataIndex: 'createDate', dataIndex: 'createDate',
    dataType : 'string', dataType: 'string',
    width : 150 width: 150
    } }
    ], ],
    pagination : true, pagination: true,
    serverSort : true, serverSort: true,
    selectable : true, selectable: true,
    multipleSelection: true multipleSelection: true
    }); });
    ...@@ -120,7 +120,7 @@ define('package/quiqqer/coupons/bin/backend/controls/Window', [ ...@@ -120,7 +120,7 @@ define('package/quiqqer/coupons/bin/backend/controls/Window', [
    onDblClick: () => { onDblClick: () => {
    this.submit(); this.submit();
    }, },
    onRefresh : this.$listRefresh onRefresh: this.$listRefresh
    }); });
    this.$Grid.refresh(); this.$Grid.refresh();
    ...@@ -148,10 +148,10 @@ define('package/quiqqer/coupons/bin/backend/controls/Window', [ ...@@ -148,10 +148,10 @@ define('package/quiqqer/coupons/bin/backend/controls/Window', [
    } }
    let GridParams = { let GridParams = {
    sortOn : Grid.getAttribute('sortOn'), sortOn: Grid.getAttribute('sortOn'),
    sortBy : Grid.getAttribute('sortBy'), sortBy: Grid.getAttribute('sortBy'),
    perPage: Grid.getAttribute('perPage'), perPage: Grid.getAttribute('perPage'),
    page : Grid.getAttribute('page') page: Grid.getAttribute('page')
    }; };
    switch (GridParams.sortOn) { switch (GridParams.sortOn) {
    ......
    bin/backend/controls/settings/CodeGeneratorSelect.js
    + 9
    − 9
    Bearbeiten Zeige Datei @ 6b1d6f44
    ...@@ -17,11 +17,11 @@ define('package/quiqqer/coupons/bin/backend/controls/settings/CodeGeneratorSelec ...@@ -17,11 +17,11 @@ define('package/quiqqer/coupons/bin/backend/controls/settings/CodeGeneratorSelec
    ], function (QUISelect, QUILoader, QUILocale, QUIAjax) { ], function (QUISelect, QUILoader, QUILocale, QUIAjax) {
    "use strict"; "use strict";
    var lg = 'quiqqer/coupons'; const lg = 'quiqqer/coupons';
    return new Class({ return new Class({
    Extends: QUISelect, Extends: QUISelect,
    Type : 'package/quiqqer/coupons/bin/backend/controls/settings/CodeGeneratorSelect', Type: 'package/quiqqer/coupons/bin/backend/controls/settings/CodeGeneratorSelect',
    Binds: [ Binds: [
    '$onImport' '$onImport'
    ...@@ -46,22 +46,22 @@ define('package/quiqqer/coupons/bin/backend/controls/settings/CodeGeneratorSelec ...@@ -46,22 +46,22 @@ define('package/quiqqer/coupons/bin/backend/controls/settings/CodeGeneratorSelec
    * Event: onImport * Event: onImport
    */ */
    $onImport: function () { $onImport: function () {
    var self = this; const self = this;
    this.$Input = this.getElm(); this.$Input = this.getElm();
    this.$Input.hidden = true; this.$Input.hidden = true;
    var Elm = this.create().inject(this.$Input, 'after'); const Elm = this.create().inject(this.$Input, 'after');
    Elm.addClass('field-container-field'); Elm.addClass('field-container-field');
    this.Loader.inject(Elm); this.Loader.inject(Elm);
    this.Loader.show(); this.Loader.show();
    this.$getCodeGenerators().then(function(codeGenerators) { this.$getCodeGenerators().then(function (codeGenerators) {
    self.Loader.hide(); self.Loader.hide();
    for (var i = 0, len = codeGenerators.length; i < len; i++) { for (let i = 0, len = codeGenerators.length; i < len; i++) {
    self.appendChild( self.appendChild(
    codeGenerators[i], codeGenerators[i],
    codeGenerators[i] codeGenerators[i]
    ...@@ -72,7 +72,7 @@ define('package/quiqqer/coupons/bin/backend/controls/settings/CodeGeneratorSelec ...@@ -72,7 +72,7 @@ define('package/quiqqer/coupons/bin/backend/controls/settings/CodeGeneratorSelec
    self.setValue(self.$Input.value); self.setValue(self.$Input.value);
    } }
    self.addEvent('onChange', function(value) { self.addEvent('onChange', function (value) {
    self.$Input.value = value; self.$Input.value = value;
    }); });
    }); });
    ...@@ -87,7 +87,7 @@ define('package/quiqqer/coupons/bin/backend/controls/settings/CodeGeneratorSelec ...@@ -87,7 +87,7 @@ define('package/quiqqer/coupons/bin/backend/controls/settings/CodeGeneratorSelec
    return new Promise(function (resolve, reject) { return new Promise(function (resolve, reject) {
    QUIAjax.get('package_quiqqer_coupons_ajax_settings_getCodeGenerators', resolve, { QUIAjax.get('package_quiqqer_coupons_ajax_settings_getCodeGenerators', resolve, {
    'package': 'quiqqer/coupons', 'package': 'quiqqer/coupons',
    onError : reject onError: reject
    }); });
    }); });
    } }
    ......
    bin/backend/load.js
    + 20
    − 20
    Bearbeiten Zeige Datei @ 6b1d6f44
    ...@@ -7,8 +7,8 @@ require(['qui/QUI'], function (QUI) { ...@@ -7,8 +7,8 @@ require(['qui/QUI'], function (QUI) {
    require(['Ajax'], function (QUIAjax) { require(['Ajax'], function (QUIAjax) {
    QUIAjax.get('package_quiqqer_coupons_ajax_backend_getCouponPrice', resolve, { QUIAjax.get('package_quiqqer_coupons_ajax_backend_getCouponPrice', resolve, {
    'package': 'quiqqer/coupons', 'package': 'quiqqer/coupons',
    couponId : couponId, couponId: couponId,
    vat : vat vat: vat
    }); });
    }); });
    }); });
    ...@@ -22,13 +22,13 @@ require(['qui/QUI'], function (QUI) { ...@@ -22,13 +22,13 @@ require(['qui/QUI'], function (QUI) {
    require(['Locale'], function (QUILocale) { require(['Locale'], function (QUILocale) {
    new Element('button', { new Element('button', {
    'class': 'qui-button', 'class': 'qui-button',
    html : '<span class="fa fa-credit-card-alt"></span>', html: '<span class="fa fa-credit-card-alt"></span>',
    title : QUILocale.get('quiqqer/coupons', 'add.coupon.priceFactor'), title: QUILocale.get('quiqqer/coupons', 'add.coupon.priceFactor'),
    styles : { styles: {
    'float' : 'right', 'float': 'right',
    marginRight: '10px' marginRight: '10px'
    }, },
    events : { events: {
    click: function (e) { click: function (e) {
    e.stop(); e.stop();
    ...@@ -37,7 +37,7 @@ require(['qui/QUI'], function (QUI) { ...@@ -37,7 +37,7 @@ require(['qui/QUI'], function (QUI) {
    ], function (CouponWindow) { ], function (CouponWindow) {
    new CouponWindow({ new CouponWindow({
    multiple: true, multiple: true,
    events : { events: {
    onSubmit: function (Instance, value) { onSubmit: function (Instance, value) {
    if (!value.length) { if (!value.length) {
    return; return;
    ...@@ -57,20 +57,20 @@ require(['qui/QUI'], function (QUI) { ...@@ -57,20 +57,20 @@ require(['qui/QUI'], function (QUI) {
    ); );
    }).then((data) => { }).then((data) => {
    let priceFactor = { let priceFactor = {
    calculation : 2, calculation: 2,
    calculation_basis: 2, calculation_basis: 2,
    description : couponData.title, description: couponData.title,
    identifier : "", identifier: "",
    index : ArticleList.countPriceFactors(), index: ArticleList.countPriceFactors(),
    nettoSum : data.nettoSum, nettoSum: data.nettoSum,
    nettoSumFormatted: data.nettoSumFormatted, nettoSumFormatted: data.nettoSumFormatted,
    sum : data.sum, sum: data.sum,
    sumFormatted : data.sumFormatted, sumFormatted: data.sumFormatted,
    title : couponData.title, title: couponData.title,
    value : data.sum, value: data.sum,
    valueText : data.valueText, valueText: data.valueText,
    vat : vat, vat: vat,
    visible : 1 visible: 1
    }; };
    ArticleList.addPriceFactor(priceFactor); ArticleList.addPriceFactor(priceFactor);
    ......
    bin/frontend/classes/CouponCodes.js
    + 3
    − 3
    Bearbeiten Zeige Datei @ 6b1d6f44
    ...@@ -13,7 +13,7 @@ define('package/quiqqer/coupons/bin/frontend/classes/CouponCodes', [ ...@@ -13,7 +13,7 @@ define('package/quiqqer/coupons/bin/frontend/classes/CouponCodes', [
    ], function (QUIAjax) { ], function (QUIAjax) {
    "use strict"; "use strict";
    var pkg = 'quiqqer/coupons'; const pkg = 'quiqqer/coupons';
    return new Class({ return new Class({
    ...@@ -30,9 +30,9 @@ define('package/quiqqer/coupons/bin/frontend/classes/CouponCodes', [ ...@@ -30,9 +30,9 @@ define('package/quiqqer/coupons/bin/frontend/classes/CouponCodes', [
    return new Promise(function (resolve, reject) { return new Promise(function (resolve, reject) {
    QUIAjax.post('package_quiqqer_coupons_ajax_frontend_redeem', resolve, { QUIAjax.post('package_quiqqer_coupons_ajax_frontend_redeem', resolve, {
    'package': pkg, 'package': pkg,
    code : code, code: code,
    orderHash: orderHash, orderHash: orderHash,
    onError : reject onError: reject
    }); });
    }); });
    } }
    ......
    0% oder .
    You are about to add 0 people to the discussion. Proceed with caution.
    Bearbeitung dieser Nachricht zuerst beenden!
    Bitte registrieren oder zum Kommentieren

    PCSG & QUIQQER support and DEV System - GitLab