Commits auf Quelle (3)
-
verfasst von Henning Leutz
This commit updates the version of phpstan specified in .phive/phars.xml file to 1.* and the current installed version to 1.12.13. Additionally, it removes all the previously ignored errors in phpstan-baseline.neon. The actions were taken possibly due to fixes to these errors or related update in the codebase causing them to be obsolete. Please ensure related checks/errors do not surface again due to the removed baseline ignores.
6f309bd3 -
verfasst von Henning Leutz
Several changes have been made across multiple files to enhance code readability and follow safer coding practices. 1. Breakdown of long lines of attributes/code into multiple lines with added comments for better readability. This was done in Submenu.php 2. Replaced '==' operation with 'empty()' function to check for empty strings in Submenu.php 3. Safer checking of if method 'getCachePath' exists on 'getSite' to avoid potential errors & Ensure the last insert ID is always an integer in the database PDO in DropDownMenu.php and Factory.php 4. Refactor conditions for more clear type hinting in multiple files; including Independent/Handler.php, Independent/Items/AbstractMenuItem.php, Independent/Items/Site.php, Independent/Menu.php, MegaMenu.php, and NavTabs.php The concept of safe concatenation or use of '|null|' has been introduced where needed across many files. Related: #38
78d9b1e2 -
verfasst von Henning Leutz
chore: update phpstan version and remove phpstan-baseline See merge request !36
- .phive/phars.xml 1 Ergänzung, 1 Löschung.phive/phars.xml
- phpstan-baseline.neon 0 Ergänzungen, 26 Löschungenphpstan-baseline.neon
- src/QUI/Menu/Bricks/Submenu.php 17 Ergänzungen, 15 Löschungensrc/QUI/Menu/Bricks/Submenu.php
- src/QUI/Menu/DropDownMenu.php 6 Ergänzungen, 4 Löschungensrc/QUI/Menu/DropDownMenu.php
- src/QUI/Menu/Independent/Factory.php 1 Ergänzung, 2 Löschungensrc/QUI/Menu/Independent/Factory.php
- src/QUI/Menu/Independent/Handler.php 4 Ergänzungen, 2 Löschungensrc/QUI/Menu/Independent/Handler.php
- src/QUI/Menu/Independent/Items/AbstractMenuItem.php 5 Ergänzungen, 5 Löschungensrc/QUI/Menu/Independent/Items/AbstractMenuItem.php
- src/QUI/Menu/Independent/Items/Site.php 3 Ergänzungen, 3 Löschungensrc/QUI/Menu/Independent/Items/Site.php
- src/QUI/Menu/Independent/Menu.php 4 Ergänzungen, 4 Löschungensrc/QUI/Menu/Independent/Menu.php
- src/QUI/Menu/MegaMenu.php 8 Ergänzungen, 7 Löschungensrc/QUI/Menu/MegaMenu.php
- src/QUI/Menu/NavTabs.php 1 Ergänzung, 2 Löschungensrc/QUI/Menu/NavTabs.php