From e433d6d322df2f3bff604e4e5927b6dd537bea96 Mon Sep 17 00:00:00 2001
From: Campii <dominik.chrzanowski183@gmail.com>
Date: Tue, 9 Nov 2021 10:56:27 +0100
Subject: [PATCH] refactor: Removed unnecessary option [Basicslider]
quiqqer/package-bricks#131
---
bricks.xml | 14 --------------
locale.xml | 12 ------------
src/QUI/Bricks/Controls/Slider/BasicSlider.html | 12 +-----------
src/QUI/Bricks/Controls/Slider/BasicSlider.php | 3 ---
4 files changed, 1 insertion(+), 40 deletions(-)
diff --git a/bricks.xml b/bricks.xml
index fecdb9b..5b18bfd 100644
--- a/bricks.xml
+++ b/bricks.xml
@@ -182,20 +182,6 @@
<locale group="quiqqer/bricks" var="brick.control.basicSlider.navigationDotsShow"/>
</setting>
- <setting name="navigationDotPosition" type="select">
- <locale group="quiqqer/bricks"
- var="brick.basicSlider.navigationDotPosition"/>
-
- <option value="underSlide">
- <locale group="quiqqer/bricks"
- var="brick.basicSlider.navigationDotPosition.underSlide"/>
- </option>
- <option value="underText">
- <locale group="quiqqer/bricks"
- var="brick.basicSlider.navigationDotPosition.underText"/>
- </option>
- </setting>
-
<setting name="maxImageWidth" type="number">
<locale group="quiqqer/bricks"
var="brick.control.basicSlider.maxImageWidth"/>
diff --git a/locale.xml b/locale.xml
index 0e69cf1..94ad8de 100644
--- a/locale.xml
+++ b/locale.xml
@@ -432,18 +432,6 @@
<de><![CDATA[Punktnavigation anzeigen]]></de>
<en><![CDATA[Show dots navigation]]></en>
</locale>
- <locale name="brick.basicSlider.navigationDotPosition">
- <de><![CDATA[Punktnavigation anzeigen]]></de>
- <en><![CDATA[Navigation position]]></en>
- </locale>
- <locale name="brick.basicSlider.navigationDotPosition.underSlide">
- <de><![CDATA[Unter Folie]]></de>
- <en><![CDATA[Under slide]]></en>
- </locale>
- <locale name="brick.basicSlider.navigationDotPosition.underText">
- <de><![CDATA[Unter Text]]></de>
- <en><![CDATA[Under text]]></en>
- </locale>
<locale name="brick.control.basicSlider.maxImageWidth">
<de><![CDATA[Maximale Briete des Bildes]]></de>
<en><![CDATA[Maximum image width]]></en>
diff --git a/src/QUI/Bricks/Controls/Slider/BasicSlider.html b/src/QUI/Bricks/Controls/Slider/BasicSlider.html
index cad298d..2b18f45 100644
--- a/src/QUI/Bricks/Controls/Slider/BasicSlider.html
+++ b/src/QUI/Bricks/Controls/Slider/BasicSlider.html
@@ -14,16 +14,6 @@
<div class="basic-slider-content" style="align-items: {$textPosition};">
<div class="basic-slider-content-container">
{$sliderContent}
-
- {if $dotsNav && $dotsPosition === 'underText'}
- <ul class="basic-slider-dots">
- {foreach from=$images item=Image key=key}
-
- <li class="basic-slider-dot"></li>
-
- {/foreach}
- </ul>
- {/if}
</div>
</div>
@@ -40,7 +30,7 @@
{/foreach}
</ul>
- {if $dotsNav && $dotsPosition === 'underSlide'}
+ {if $dotsNav}
<ul class="basic-slider-dots">
{foreach from=$images item=Image key=key}
diff --git a/src/QUI/Bricks/Controls/Slider/BasicSlider.php b/src/QUI/Bricks/Controls/Slider/BasicSlider.php
index 21fccc3..0fda85c 100644
--- a/src/QUI/Bricks/Controls/Slider/BasicSlider.php
+++ b/src/QUI/Bricks/Controls/Slider/BasicSlider.php
@@ -52,7 +52,6 @@ public function getBody()
$sliderContent = $this->getAttribute('sliderContent');
$imgLeft = false;
$dotsNav = false;
- $dotsPosition = 'underSlide';
if (!$mediaFolder) {
return '';
@@ -96,7 +95,6 @@ public function getBody()
}
$dotsNav = $this->getAttribute('navigationDotsShow');
- $dotsPosition = $this->getAttribute('navigationDotPosition');
// text position
switch ($this->getAttribute('textPosition')) {
@@ -121,7 +119,6 @@ public function getBody()
'maxImageWidth' => $maxImageWidth,
'textPosition' => $textPosition,
'dotsNav' => $dotsNav,
- 'dotsPosition' => $dotsPosition,
];
$Engine->assign($options);
--
GitLab