From cf4d1cdebb18cd2170fad123b6c66a1e07e7de62 Mon Sep 17 00:00:00 2001
From: Henning Leutz <leutz@pcsg.de>
Date: Tue, 11 Feb 2020 15:28:50 +0100
Subject: [PATCH] refactor: mobild and desktop detection -> server side
---
.../Controls/Slider/PromosliderWallpaper.html | 6 +++++-
.../Controls/Slider/PromosliderWallpaper.php | 5 +++++
.../Slider/PromosliderWallpaper2Content.html | 16 ++++++++--------
3 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.html b/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.html
index c16ee8f..f6ad42f 100644
--- a/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.html
+++ b/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.html
@@ -1,4 +1,5 @@
<div class="quiqqer-bricks-promoslider-wallpaper-container">
+ {if $isDesktop}
{strip}
<ul class="hide-on-mobile">
{foreach $desktopSlides as $key => $slide}
@@ -39,7 +40,9 @@
{/foreach}
</ul>
{/strip}
+ {/if}
+ {if $isMobile}
{strip}
<ul class="hide-on-desktop">
{foreach $mobileSlides as $key => $slide}
@@ -79,6 +82,7 @@
{/foreach}
</ul>
{/strip}
+ {/if}
</div>
<div class="quiqqer-bricks-promoslider-wallpaper-dots"></div>
@@ -91,4 +95,4 @@
{$this->getAttribute('showarrows')}">
<span class="fa fa-chevron-right"></span>
</div>
-{/if}
\ No newline at end of file
+{/if}
diff --git a/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.php b/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.php
index df0eeef..8b1450e 100644
--- a/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.php
+++ b/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.php
@@ -239,6 +239,11 @@ public function getBody()
$Engine->assign($options);
+ $Engine->assign([
+ 'isMobile' => QUI\MobileDetection::isMobile(),
+ 'isDesktop' => QUI\MobileDetection::isDesktop()
+ ]);
+
return $Engine->fetch($this->getAttribute('template'));
}
}
diff --git a/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper2Content.html b/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper2Content.html
index 44d589a..47adb2b 100644
--- a/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper2Content.html
+++ b/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper2Content.html
@@ -21,8 +21,8 @@
{if $key === 0}
<noscript>
- {if $slide.url}<a href="{$slide.url}" {if $slide.newTab}target="_blank"{/if}>{/if}
- {image image=$slide.image class="quiqqer-bricks-promoslider-wallpaper2Content-noScriptImage"}
+ {if $slide.url}<a href="{$slide.url}" {if $slide.newTab}target="_blank" {/if}>{/if}
+ {image image=$slide.image class="quiqqer-bricks-promoslider-wallpaper2Content-noScriptImage"}
{if $slide.url}</a>{/if}
</noscript>
{/if}
@@ -32,6 +32,7 @@
</ul>
{/strip}
+ {if $isMobile}
{strip}
<ul class="hide-on-desktop">
{foreach $mobileSlides as $key => $slide}
@@ -54,8 +55,8 @@
{if $key === 0}
<noscript>
- {if $slide.url}<a href="{$slide.url}" {if $slide.newTab}target="_blank"{/if}>{/if}
- {image image=$slide.image class="quiqqer-bricks-promoslider-wallpaper2Content-noScriptImage"}
+ {if $slide.url}<a href="{$slide.url}" {if $slide.newTab}target="_blank" {/if}>{/if}
+ {image image=$slide.image class="quiqqer-bricks-promoslider-wallpaper2Content-noScriptImage"}
{if $slide.url}</a>{/if}
</noscript>
{/if}
@@ -64,16 +65,15 @@
{/foreach}
</ul>
{/strip}
+ {/if}
</div>
<div class="quiqqer-bricks-promoslider-wallpaper-dots"></div>
{if count($desktopSlides) > 1 && $this->getAttribute('showarrows') != 'hide'}
-<div class="quiqqer-bricks-promoslider-wallpaper-prev hide-on-mobile
- {$this->getAttribute('showarrows')}">
+<div class="quiqqer-bricks-promoslider-wallpaper-prev hide-on-mobile {$this->getAttribute('showarrows')}">
<span class="fa fa-chevron-left"></span>
</div>
-<div class="quiqqer-bricks-promoslider-wallpaper-next hide-on-mobile
- {$this->getAttribute('showarrows')}">
+<div class="quiqqer-bricks-promoslider-wallpaper-next hide-on-mobile {$this->getAttribute('showarrows')}">
<span class="fa fa-chevron-right"></span>
</div>
--
GitLab