From 965615ebc65264af3909fb0efcb21df668b9d8dc Mon Sep 17 00:00:00 2001
From: Jan Wennrich <jan.wennrich@pcsg.de>
Date: Fri, 30 Nov 2018 18:42:19 +0100
Subject: [PATCH] fix: don't add a-tag to slides if no url is set (#87)
---
.../Bricks/Controls/Slider/Promoslider.html | 8 +++----
.../Controls/Slider/PromosliderWallpaper.html | 17 ++++---------
.../Slider/PromosliderWallpaper2Content.html | 24 +++++++------------
3 files changed, 17 insertions(+), 32 deletions(-)
diff --git a/src/QUI/Bricks/Controls/Slider/Promoslider.html b/src/QUI/Bricks/Controls/Slider/Promoslider.html
index f5500be..d29887d 100644
--- a/src/QUI/Bricks/Controls/Slider/Promoslider.html
+++ b/src/QUI/Bricks/Controls/Slider/Promoslider.html
@@ -22,7 +22,7 @@
data-href="{$slide.url}"
data-newTab="{$slide.newTab}"
>
- <a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>
+ {if $slide.url}<a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>{/if}
{if $slide.image && $this->getAttribute('image-as-wallpaper')}
<div class="quiqqer-bricks-promoslider-slide-image quiqqer-bricks-promoslider-slide-image__cover"
style="background-image: url('{image image=$slide.image onlysrc=1 width=1900}')"
@@ -52,7 +52,7 @@
{/if}
</div>
</div>
- </a>
+ {if $slide.url}</a>{/if}
</div>
{/foreach}
<div class="quiqqer-bricks-promoslider-slide-desktop-dots"></div>
@@ -71,7 +71,7 @@
data-newTab="{$slide.newTab}"
role="option"
>
- <a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>
+ {if $slide.url}<a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>{/if}
{if $slide.image && $this->getAttribute('image-as-wallpaper')}
<div class="quiqqer-bricks-promoslider-slide-mobile-image quiqqer-bricks-promoslider-slide-image__cover"
style="background-image: url('{image image=$slide.image onlysrc=1 width=1900}')"
@@ -99,7 +99,7 @@
</div>
{/if}
</div>
- </a>
+ {if $slide.url}</a>{/if}
</div>
{/foreach}
diff --git a/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.html b/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.html
index 9ac69f7..c16ee8f 100644
--- a/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.html
+++ b/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper.html
@@ -3,9 +3,7 @@
<ul class="hide-on-mobile">
{foreach $desktopSlides as $key => $slide}
<li data-image="{image image=$slide.image onlysrc=1}" data-href="{$slide.url}" data-newTab="{$slide.newTab}">
- {if $slide.url}
- <a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>
- {/if}
+ {if $slide.url}<a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>{/if}
{assign var=extraClass value=""}
{if isset($slide.pos) && $slide.pos == 'quiqqer-bricks-promoslider-slide-right'}
@@ -36,10 +34,7 @@
</div>
{/if}
-
- {if $slide.url}
- </a>
- {/if}
+ {if $slide.url}</a>{/if}
</li>
{/foreach}
</ul>
@@ -49,7 +44,7 @@
<ul class="hide-on-desktop">
{foreach $mobileSlides as $key => $slide}
<li data-image="{image image=$slide.image onlysrc=1}" data-href="{$slide.url}" data-newTab="{$slide.newTab}">
- <a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>
+ {if $slide.url}<a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>{/if}
{assign var=extraClass value=""}
{if isset($slide.pos) && $slide.pos == 'quiqqer-bricks-promoslider-slide-right'}
@@ -78,10 +73,8 @@
{/if}
</div>
</div>
- {/if}
-
-
- </a>
+ {/if}
+ {if $slide.url}</a>{/if}
</li>
{/foreach}
</ul>
diff --git a/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper2Content.html b/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper2Content.html
index 874f23d..44d589a 100644
--- a/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper2Content.html
+++ b/src/QUI/Bricks/Controls/Slider/PromosliderWallpaper2Content.html
@@ -3,7 +3,7 @@
<ul class="hide-on-mobile">
{foreach $desktopSlides as $key => $slide}
<li data-image="{image image=$slide.image onlysrc=1}" data-href="{$slide.url}" data-newTab="{$slide.newTab}">
- <a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>
+ {if $slide.url}<a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>{/if}
<div class="quiqqer-bricks-promoslider-wallpaper-image" style="display: none"> </div>
<div class="grid-container">
@@ -21,16 +21,12 @@
{if $key === 0}
<noscript>
- {if $slide.url}
- <a href="{$slide.url}" {if $slide.newTab}target="_blank"{/if}>
- {/if}
+ {if $slide.url}<a href="{$slide.url}" {if $slide.newTab}target="_blank"{/if}>{/if}
{image image=$slide.image class="quiqqer-bricks-promoslider-wallpaper2Content-noScriptImage"}
- {if $slide.url}
- </a>
- {/if}
+ {if $slide.url}</a>{/if}
</noscript>
{/if}
- </a>
+ {if $slide.url}</a>{/if}
</li>
{/foreach}
</ul>
@@ -40,7 +36,7 @@
<ul class="hide-on-desktop">
{foreach $mobileSlides as $key => $slide}
<li data-image="{image image=$slide.image onlysrc=1}" data-href="{$slide.url}" data-newTab="{$slide.newTab}">
- <a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>
+ {if $slide.url}<a href="{$slide.url}" {if $slide.newTab} target="_blank" {/if}>{/if}
<div class="quiqqer-bricks-promoslider-wallpaper-image" style="display: none"> </div>
<div class="grid-container">
@@ -58,16 +54,12 @@
{if $key === 0}
<noscript>
- {if $slide.url}
- <a href="{$slide.url}" {if $slide.newTab}target="_blank"{/if}>
- {/if}
+ {if $slide.url}<a href="{$slide.url}" {if $slide.newTab}target="_blank"{/if}>{/if}
{image image=$slide.image class="quiqqer-bricks-promoslider-wallpaper2Content-noScriptImage"}
- {if $slide.url}
- </a>
- {/if}
+ {if $slide.url}</a>{/if}
</noscript>
{/if}
- </a>
+ {if $slide.url}</a>{/if}
</li>
{/foreach}
</ul>
--
GitLab