From 60ab2702e5eda5285ce15eebbcb6158d355eeb6a Mon Sep 17 00:00:00 2001
From: "michael.danielczok" <michael@pcsg.de>
Date: Wed, 20 Oct 2021 15:33:06 +0200
Subject: [PATCH] refactor: code refactor, smallcss  improvement [BasicSlider]
 quiqqer/package-bricks#128

---
 locale.xml                                      |  4 ++--
 src/QUI/Bricks/Controls/Slider/BasicSlider.css  | 13 +++++++++----
 src/QUI/Bricks/Controls/Slider/BasicSlider.html |  8 +++++---
 src/QUI/Bricks/Controls/Slider/BasicSlider.php  |  3 ---
 4 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/locale.xml b/locale.xml
index 39104b2..c296fb5 100644
--- a/locale.xml
+++ b/locale.xml
@@ -417,8 +417,8 @@
             <en><![CDATA[A simple image slider. The slider is displayed next to the text (optionally on the left or right).]]></en>
         </locale>
         <locale name="brick.control.basicSlider.mediaFolder">
-            <de><![CDATA[Images folder]]></de>
-            <en><![CDATA[Media-Ordner auswählen]]></en>
+            <de><![CDATA[Media-Ordner auswählen]]></de>
+            <en><![CDATA[Images folder]]></en>
         </locale>
         <locale name="brick.control.basicSlider.settings.delay">
             <de><![CDATA[Zeit zum nächsten Slide (Verzögerung)]]></de>
diff --git a/src/QUI/Bricks/Controls/Slider/BasicSlider.css b/src/QUI/Bricks/Controls/Slider/BasicSlider.css
index 8eaa0e2..255bec7 100644
--- a/src/QUI/Bricks/Controls/Slider/BasicSlider.css
+++ b/src/QUI/Bricks/Controls/Slider/BasicSlider.css
@@ -31,7 +31,6 @@
 }
 
 .basic-slider-content {
-    padding-right: 20px;
     display: flex;
 }
 
@@ -40,9 +39,15 @@
     flex-direction: row-reverse;
 }
 
-.basic-slider__imageLeft .basic-slider-content{
-    padding-right: 0;
-    padding-left: 20px;
+@media screen and (min-width: 768px) {
+    .basic-slider-content {
+        padding-right: 20px;
+    }
+
+    .basic-slider__imageLeft .basic-slider-content{
+        padding-right: 0;
+        padding-left: 20px;
+    }
 }
 
 @media screen and (max-width: 768px) {
diff --git a/src/QUI/Bricks/Controls/Slider/BasicSlider.html b/src/QUI/Bricks/Controls/Slider/BasicSlider.html
index e39e469..2c2473c 100644
--- a/src/QUI/Bricks/Controls/Slider/BasicSlider.html
+++ b/src/QUI/Bricks/Controls/Slider/BasicSlider.html
@@ -12,16 +12,18 @@
 
 <div class="basic-slider-wrapper {if $imgLeft} basic-slider__imageLeft {/if}">
     <div class="basic-slider-content" style="align-items: {$textPosition};">
-        {$sliderContent}
+        <div class="basic-slider-content-container">
+            {$sliderContent}
+        </div>
     </div>
 
     <div class="basic-slider-image-wrapper">
         <ul class="basic-slider-images">
             {assign var=showFirstImage value=true}
             {foreach from=$images item=Image}
-                <li data-image="{image image=$Image onlysrc=1 width=$maxImageWidth}">
+                <li data-image="{image image=$Image onlysrc=1 width="$maxImageWidth"}">
                     {if $showFirstImage}
-                        {image image=$Image width="{$maxImageWidth}"}
+                        {image image=$Image width="$maxImageWidth"}
                         {assign var=showFirstImage value=false}
                     {/if}
                 </li>
diff --git a/src/QUI/Bricks/Controls/Slider/BasicSlider.php b/src/QUI/Bricks/Controls/Slider/BasicSlider.php
index 223ee91..a5951dd 100644
--- a/src/QUI/Bricks/Controls/Slider/BasicSlider.php
+++ b/src/QUI/Bricks/Controls/Slider/BasicSlider.php
@@ -38,9 +38,6 @@ public function __construct($attributes = [])
         $this->addCSSFile(
             \dirname(__FILE__) . '/BasicSlider.css'
         );
-
-        $this->addCSSClass('grid-100');
-        $this->addCSSClass('mobile-grid-100');
     }
 
 
-- 
GitLab