From 4a5678bc01fef283d22e6804382df0fa5a2f9955 Mon Sep 17 00:00:00 2001 From: Jan Wennrich <jan@pcsg.de> Date: Tue, 31 Jul 2018 12:16:31 +0200 Subject: [PATCH] refactor: MobileSlidesSetting-Switch now makes use of QUISwitch's new load-event (#88) --- bin/Controls/Slider/ToggleMobileSlidesSetting.js | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/bin/Controls/Slider/ToggleMobileSlidesSetting.js b/bin/Controls/Slider/ToggleMobileSlidesSetting.js index b6715b4..868dbea 100644 --- a/bin/Controls/Slider/ToggleMobileSlidesSetting.js +++ b/bin/Controls/Slider/ToggleMobileSlidesSetting.js @@ -46,19 +46,16 @@ define('package/quiqqer/bricks/bin/Controls/Slider/ToggleMobileSlidesSetting', [ this.$Switch = new QUISwitch({ status: this.getElm().value === "true", events: { - onChange: this.$switchToggled + onChange: this.$switchToggled, + onLoad: function() { + if (!this.$Switch.getStatus()) { + this.hideMobileSlidesSetting(); + } + }.bind(this) } }).inject(Wrapper); Wrapper.wraps(this.getElm()); - - if (!this.$Switch.getStatus()) { - // Wait for the MobileSlides-control to be loaded before it can be hidden - // TODO: Maybe there is a better way than setTimeout()? - setTimeout(function() { - this.hideMobileSlidesSetting(); - }.bind(this), 200); - } }, -- GitLab