From 353db85da21e3adf962fe3e5690f6d15b01b9034 Mon Sep 17 00:00:00 2001 From: Campii <dominik.chrzanowski183@gmail.com> Date: Tue, 9 Nov 2021 11:08:31 +0100 Subject: [PATCH] refactor: Code refactor [Basicslider] quiqqer/package-bricks#131 --- bin/Controls/Slider/BasicSlider.js | 10 ++-------- src/QUI/Bricks/Controls/Slider/BasicSlider.css | 3 ++- src/QUI/Bricks/Controls/Slider/BasicSlider.html | 2 +- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/bin/Controls/Slider/BasicSlider.js b/bin/Controls/Slider/BasicSlider.js index 59ab3fe..5b79412 100644 --- a/bin/Controls/Slider/BasicSlider.js +++ b/bin/Controls/Slider/BasicSlider.js @@ -134,10 +134,7 @@ define('package/quiqqer/bricks/bin/Controls/Slider/BasicSlider', [ }); if (self.Dots) { - moofx(self.Dot).animate({ - 'background-color': 'rgba(0,0,0,0)', - 'border-color': '#e2e2e2' - }); + self.Dot.classList.remove('active'); } }); }, @@ -163,10 +160,7 @@ define('package/quiqqer/bricks/bin/Controls/Slider/BasicSlider', [ }); if (self.Dots) { - moofx(self.NextDot).animate({ - 'background-color': '#2681da', - 'border-color': '#2681da' - }); + self.NextDot.classList.add('active'); } }); }, diff --git a/src/QUI/Bricks/Controls/Slider/BasicSlider.css b/src/QUI/Bricks/Controls/Slider/BasicSlider.css index e1ff313..071b11a 100644 --- a/src/QUI/Bricks/Controls/Slider/BasicSlider.css +++ b/src/QUI/Bricks/Controls/Slider/BasicSlider.css @@ -51,9 +51,10 @@ border: 2px solid #e2e2e2; border-radius: 50%; margin: 0 5px; + transition: all 0.2s ease-in-out; } -.basic-slider-dots li:first-child { +.basic-slider-dots li.active { background-color: #2681da; border-color: #2681da; } diff --git a/src/QUI/Bricks/Controls/Slider/BasicSlider.html b/src/QUI/Bricks/Controls/Slider/BasicSlider.html index 2b18f45..5b9fee5 100644 --- a/src/QUI/Bricks/Controls/Slider/BasicSlider.html +++ b/src/QUI/Bricks/Controls/Slider/BasicSlider.html @@ -34,7 +34,7 @@ <ul class="basic-slider-dots"> {foreach from=$images item=Image key=key} - <li class="basic-slider-dot"></li> + <li class="basic-slider-dot {if $key===0}active{/if}"></li> {/foreach} </ul> -- GitLab