- Mär 05, 2025
-
-
verfasst von Patrick Müller
fix: only show cancel btn in correct circumstances; use correct verification class for cancel abort See merge request !21
-
verfasst von Patrick Müller
-
- Mär 04, 2025
-
-
verfasst von Patrick Müller
Next 2.x See merge request !20
-
verfasst von Patrick Müller
-
verfasst von Patrick Müller
-
verfasst von Patrick Müller
fix: query quiqqer user int id for membership users See merge request !18
-
verfasst von Patrick Müller
-
verfasst von Patrick Müller
-
verfasst von Henning Leutz
chore: update phpstan version in phive configuration See merge request !16
-
verfasst von Henning Leutz
fix: improve type consistency and readability in memberships See merge request !15
-
verfasst von Henning Leutz
Updated the phpstan-baseline.neon file to ignore an error regarding the return type of the getContract() method in the MembershipUser class.
-
verfasst von Henning Leutz
Adjusted the handling of the missing `QUI\\ERP\\Accounting\\Contracts\\Contract` class within the `getCurrentCancelEndDate()` method of MembershipUser to return the cycle end date. This ensures the correct return of an end date even if the contract class doesn't exist.
-
verfasst von Henning Leutz
Added checks for the existence of various classes from quiqqer/erp before trying to use them. This ensures that the code fails gracefully if the expected classes are not present, for instance if the quiqqer/erp package is not installed. Also added a new dependency on quiqqer/erp in `composer.json`. This will prevent the code from being installed without the necessary package, but in case it's removed or not loaded for some reason, the new checks still provide a safety net.
-
verfasst von Henning Leutz
This commit adds checks to ensure that specific classes exist before they are used. This adds greater fault tolerance to the code by precluding attempts to use non-existent classes which would cause a fatal error. This has been applied to functions within the 'Handler.php' and 'Membership.php' files. In 'Handler.php', checks have been added for existence of the 'QUI\\ERP\\Products\\Handler\\Categories' and 'QUI\\ERP\\Products\\Handler\\Fields' classes. In 'Membership.php', checks have been added for 'QUI\\ERP\\Products\\Search\\BackendSearch', 'QUI\\ERP\\Products\\Handler\\Products', 'QUI\\ERP\\Products\\Handler\\Fields', 'QUI\\ERP\\Plans\\Handler', and 'QUI\\ERP\\Plans\\PlanProduct'.
-
verfasst von Henning Leutz
Added checks to confirm existence of certain classes before their use in ajax/memberships/lock.php, ajax/memberships/products/getMembershipProducts.php and ajax/memberships/unlock.php. This change helps prevent unexpected errors during runtime.
-
verfasst von Patrick Müller
-
verfasst von Henning Leutz
This commit refactors `MembershipUser.php` to improve code readability. It does this by including spaces around the concatenation operators for better visual separation. This makes the identifiers for verification checks much more readable.
-
verfasst von Henning Leutz
The membership-related code was cleaned up across `getList.php`, `Handler.php`, `Membership.php`, `Users/Handler.php`, and `Users/MembershipUser.php` files. Removed unnecessary comments and @phpstan-ignore lines. Added strict type checking where it was missing and restructured some conditions for better readability. Also, simplified the return statements in some methods.
-
verfasst von Patrick Müller
-
verfasst von Henning Leutz
This commit refactors several areas of the code to improve type definitions and error handling. Main changes include: - Improved the type definitions for function arguments and return types within the Handler, Membership and Users Handler classes. - Added error handling for instances where the Membership is not an instance of QUI\Memberships\Membership. - Updated the commenting style to more clearly define variables. - Changed the use of \PDO to PDO for cleaner code. - Removed unnecessary conditionals in the WHERE clause building of an SQL query, leading to cleaner, more straightforward code.
-
verfasst von Henning Leutz
- Removed redundant docblock. - Added instance check for `$User` before attempting to remove it from groups to prevent potential errors. - Ensured `hasMembershipUserId` method exists before calling it to prevent undefined method errors. - Adjusted `addHistoryEntry` function to receive a string as the second parameter instead of an array. - Removed redundant array-to-string conversion in `addHistoryEntry` function. - Ignored `phpstan` warning regarding method's return type.
-
verfasst von Henning Leutz
This commit addresses three major updates in our Memberships module: 1. In Handler.php, we clarified the return type of `isLinkedToContracts()` method by explicitly defining it as boolean. 2. In AbstractMembershipUserLinkVerificationHandler.php, we simplified the Exception import and updated the type in the `getMembershipUser()` method's doc comment. 3. In MembershipUser.php, the constructors for `CancelVerification` and `AbortCancelVerification` are now called without the user id. These changes enhance code readability and maintainability while ensuring safer calls.
-
verfasst von Henning Leutz
This commit improves the type consistency and readability of the code in the Membership class and related classes. The changes include adding strict types, removing unused imports, using type hinting, and replacing old switch-case syntax with match expressions. Specifically, it changes the signature of several functions, adds and removes some class imports, and replaces old style function syntax with modern type hinting for better readability and maintainability. Moreover, it adds PHP built-in functions instead of using their fully qualified form. It also improves readability by replacing the switch-case syntax with the new and more convenient match expression when parsing intervals from the duration.
-
verfasst von Henning Leutz
-
- Mär 03, 2025
-
-
verfasst von Henning Leutz
The phive configuration has been updated to reflect the new version of phpstan that is being used. The version has been changed from 1.11.8 to a generic 1.* with the installed version now at 1.12.13.
-
- Jan 08, 2025
-
-
verfasst von Patrick Müller
Next 2.x See merge request !14
-
verfasst von Patrick Müller
-
verfasst von Jan Wennrich
-
verfasst von Patrick Müller
Next 2.x See merge request !13
-
verfasst von Patrick Müller
-
verfasst von Patrick Müller
-
- Jan 03, 2025
-
-
verfasst von Henning Leutz
chore: add .gitattributes file See merge request !11
-
verfasst von Henning Leutz
(cherry picked from commit 7ccb4fbd) Co-authored-by:
Jan Wennrich <jan.wennrich@pcsg.de>
-
verfasst von Henning Leutz
(cherry picked from commit 29ece0ed) Co-authored-by:
Jan Wennrich <jan.wennrich@pcsg.de>
-
verfasst von Henning Leutz
(cherry picked from commit 31ef9697) Co-authored-by:
Jan Wennrich <jan.wennrich@pcsg.de>
-
verfasst von Henning Leutz
(cherry picked from commit 16e44cb5) Co-authored-by:
Jan Wennrich <jan.wennrich@pcsg.de>
-
verfasst von Henning Leutz
(cherry picked from commit 68ccf614) Co-authored-by:
Jan Wennrich <jan.wennrich@pcsg.de>
-
verfasst von Henning Leutz
(cherry picked from commit b74cc654) Co-authored-by:
Jan Wennrich <jan.wennrich@pcsg.de>
-
verfasst von Henning Leutz
(cherry picked from commit 4e5739b3) Co-authored-by:
Jan Wennrich <jan.wennrich@pcsg.de>
-
verfasst von Henning Leutz
(cherry picked from commit 5ace2927) Co-authored-by:
Jan Wennrich <jan.wennrich@pcsg.de>
-