From 23c57d4f4a72794acb9250f6ad406216e5904b85 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Patrick=20M=C3=BCller?= <p.mueller@pcsg.de>
Date: Tue, 24 Sep 2024 16:38:01 +0200
Subject: [PATCH] fix: groupId must not be necessarily int; error on wrong
field type
---
src/QUI/Memberships/Events.php | 5 +++++
src/QUI/Memberships/Handler.php | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/QUI/Memberships/Events.php b/src/QUI/Memberships/Events.php
index 28165c6..4d91eec 100644
--- a/src/QUI/Memberships/Events.php
+++ b/src/QUI/Memberships/Events.php
@@ -186,6 +186,11 @@ protected static function createProductFields()
QUI\System\Log::addError(self::class . ' :: createProductFields');
QUI\System\Log::writeException($Exception);
}
+ } elseif (!($MembershipField instanceof MembershipField)) {
+ QUI\System\Log::addError(
+ 'quiqqer/memberships :: Cannot create memership field because product field with ID ' .
+ $MembershipField->getId() . ' is not a membership field.'
+ );
}
// Membership flag field (create new one is not configured)
diff --git a/src/QUI/Memberships/Handler.php b/src/QUI/Memberships/Handler.php
index aa68cf4..24fa83a 100644
--- a/src/QUI/Memberships/Handler.php
+++ b/src/QUI/Memberships/Handler.php
@@ -66,7 +66,7 @@ public function createChild($data = []): QUI\CRUD\Child
foreach ($groupIds as $groupId) {
// check if group exist by getting them
- $Groups->get((int)$groupId);
+ $Groups->get($groupId);
}
$data['groupIds'] = ',' . implode(',', $groupIds) . ',';
--
GitLab