From 14c81345fb656fc161fc81e85eeacf2b4d52d01f Mon Sep 17 00:00:00 2001 From: Campii <dominik.chrzanowski183@gmail.com> Date: Sun, 31 Oct 2021 13:37:29 +0100 Subject: [PATCH] refactor: Code refactor [IntervieweeData] quiqqer/interview#2 --- .../IntervieweeData.LargeImageTop.html | 18 ++++++++---------- src/QUI/Interview/Controls/IntervieweeData.php | 13 +++---------- 2 files changed, 11 insertions(+), 20 deletions(-) diff --git a/src/QUI/Interview/Controls/IntervieweeData.LargeImageTop.html b/src/QUI/Interview/Controls/IntervieweeData.LargeImageTop.html index e87aa55..6c2f432 100644 --- a/src/QUI/Interview/Controls/IntervieweeData.LargeImageTop.html +++ b/src/QUI/Interview/Controls/IntervieweeData.LargeImageTop.html @@ -1,14 +1,12 @@ -<div class="quiqqer-interview-interviewee"> - - <div class="quiqqer-interview-interviewee-image"> - {image src=$intervieweeAvatar width=300 height=300 loading="lazy"} +<div class="quiqqer-interview-control-interviewee-template__largeImageTop"> + <div class="quiqqer-interview-control-interviewee-image"> + {image src=$intervieweeAvatar width="500" height="500" loading="lazy"} </div> - <div class="quiqqer-interview-interviewee-name"> {$intervieweeName} </div> - <div class="quiqqer-interview-interviewee-additionalInfo"> {$intervieweeAdditionalInfo} </div> - - <div class="quiqqer-interview-interviewee-description"> - {$intervieweeDescription} - </div> + <p class="quiqqer-interview-control-interviewee-name">{$intervieweeName}</p> + <p class="quiqqer-interview-control-interviewee-additionalInfo">{$intervieweeAdditionalInfo}</p> + {if $intervieweeDescription} + <div class="quiqqer-interview-control-interviewee-short">{$intervieweeDescription}</div> + {/if} </div> \ No newline at end of file diff --git a/src/QUI/Interview/Controls/IntervieweeData.php b/src/QUI/Interview/Controls/IntervieweeData.php index 28cfdf0..400304a 100644 --- a/src/QUI/Interview/Controls/IntervieweeData.php +++ b/src/QUI/Interview/Controls/IntervieweeData.php @@ -51,17 +51,14 @@ public function getBody() switch ($this->getAttribute('interviewee-template')) { case 'largeImageLeft': - $html = '/IntervieweeData.largeImageLeft.html'; - $css = '/IntervieweeData.largeImageLeft.css'; + $html = '/IntervieweeData.LargeImageLeft.html'; break; case 'smallImageLeft': - $html = '/IntervieweeData.smallImageLeft.html'; - $css = '/IntervieweeData.smallImageLeft.css'; + $html = '/IntervieweeData.SmallImageLeft.html'; break; case 'largeImageTop': default: - $html = '/IntervieweeData.largeImageTop.html'; - $css = '/IntervieweeData.largeImageTop.css'; + $html = '/IntervieweeData.LargeImageTop.html'; break; } @@ -84,10 +81,6 @@ public function getBody() 'intervieweeDescription' => $intervieweeData['intervieweeDescription'] ]); - $this->addCSSFile( - dirname(__FILE__) . $css - ); - $Engine->assign('controlTemplate', $Engine->fetch(dirname(__FILE__) . $html)); return $Engine->fetch(dirname(__FILE__) . '/IntervieweeData.html'); -- GitLab