From 462302bd937ca4fd0a00d4791246cc13580cb83e Mon Sep 17 00:00:00 2001
From: Henning <leutz@pcsg.de>
Date: Tue, 25 Feb 2025 08:02:58 +0100
Subject: [PATCH 1/2] fix(CalculationValue): precision - bool int error
---
src/QUI/ERP/Accounting/CalculationValue.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/QUI/ERP/Accounting/CalculationValue.php b/src/QUI/ERP/Accounting/CalculationValue.php
index 1d7c769..acc33da 100644
--- a/src/QUI/ERP/Accounting/CalculationValue.php
+++ b/src/QUI/ERP/Accounting/CalculationValue.php
@@ -71,10 +71,10 @@ public function value(): float | int
/**
* Return the CalculationValue with the wanted precision
*
- * @param bool $precision
+ * @param bool|int $precision
* @return CalculationValue
*/
- public function precision(bool $precision = false): CalculationValue
+ public function precision(bool | int $precision = false): CalculationValue
{
if ($precision === false) {
return $this;
--
GitLab
From 6748a193a85bd079ee3c824bd31537dd8db59600 Mon Sep 17 00:00:00 2001
From: Henning <leutz@pcsg.de>
Date: Tue, 25 Feb 2025 08:03:43 +0100
Subject: [PATCH 2/2] refactor: remove unnecessary comments in user conversion
Removed some superfluous comments and exception declaration in the `convertUserToErpUser` function
within the `User.php` class. These comments were not adding any useful information, and the
exception mentioned was not being thrown, hence their removal.
---
src/QUI/ERP/User.php | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/QUI/ERP/User.php b/src/QUI/ERP/User.php
index 64d5d75..c4c8838 100644
--- a/src/QUI/ERP/User.php
+++ b/src/QUI/ERP/User.php
@@ -209,8 +209,6 @@ public static function getMissingAttributes(array $attributes): array
*
* @param UserInterface $User
* @return self
- *
- * @throws QUI\ERP\Exception
*/
public static function convertUserToErpUser(UserInterface $User): User
{
@@ -224,7 +222,6 @@ public static function convertUserToErpUser(UserInterface $User): User
$address = false;
if (!QUI::getUsers()->isNobodyUser($User) && !QUI::getUsers()->isSystemUser($User)) {
- /* @var $Address QUI\Users\Address */
$Address = $User->getStandardAddress();
if ($Address) {
--
GitLab