From 9289fdee7288fdef112430d57631c026d73355c0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Patrick=20M=C3=BCller?= <p.mueller@pcsg.de>
Date: Thu, 24 Feb 2022 09:18:59 +0100
Subject: [PATCH] fix: purchase quantity from/to validation
---
src/QUI/ERP/Discount/Discount.php | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/QUI/ERP/Discount/Discount.php b/src/QUI/ERP/Discount/Discount.php
index 86c298a..0c158d8 100644
--- a/src/QUI/ERP/Discount/Discount.php
+++ b/src/QUI/ERP/Discount/Discount.php
@@ -142,29 +142,28 @@ public function __construct($id, Handler $Factory)
$purchaseValueFrom = $this->getAttribute('purchase_value_from');
$purchaseValueUntil = $this->getAttribute('purchase_value_until');
-
- if ($purchaseQuantityFrom === false || $purchaseQuantityFrom < 0) {
+ if ($purchaseQuantityFrom !== '' && ($purchaseQuantityFrom === false || $purchaseQuantityFrom < 0)) {
throw new QUI\ERP\Discount\Exception([
'quiqqer/discount',
'exception.discount.purchase_quantity_from.wrong'
]);
}
- if ($purchaseQuantityUntil === false || $purchaseQuantityUntil < 0) {
+ if ($purchaseQuantityUntil !== '' && ($purchaseQuantityUntil === false || $purchaseQuantityUntil < 0)) {
throw new QUI\ERP\Discount\Exception([
'quiqqer/discount',
'exception.discount.purchase_quantity_until.wrong'
]);
}
- if ($purchaseValueFrom === false || $purchaseValueFrom < 0) {
+ if ($purchaseValueFrom !== '' && ($purchaseValueFrom === false || $purchaseValueFrom < 0)) {
throw new QUI\ERP\Discount\Exception([
'quiqqer/discount',
'exception.discount.purchase_value_from.wrong'
]);
}
- if ($purchaseValueUntil === false || $purchaseValueUntil < 0) {
+ if ($purchaseValueUntil !== '' && ($purchaseValueUntil === false || $purchaseValueUntil < 0)) {
throw new QUI\ERP\Discount\Exception([
'quiqqer/discount',
'exception.discount.purchase_value_until.wrong'
--
GitLab