From 75dc953697326a35023839596e31147c42cb9111 Mon Sep 17 00:00:00 2001
From: Henning Leutz <leutz@pcsg.de>
Date: Thu, 4 Mar 2021 15:32:50 +0100
Subject: [PATCH] refactor: code cleanup
---
bin/classes/Handler.js | 4 ----
bin/controls/DiscountEdit.js | 4 ++--
bin/controls/search/Result.js | 6 ------
bin/controls/search/Search.js | 14 +-------------
bin/controls/search/Window.js | 7 -------
5 files changed, 3 insertions(+), 32 deletions(-)
diff --git a/bin/classes/Handler.js b/bin/classes/Handler.js
index ff55c8d..ca28303 100644
--- a/bin/classes/Handler.js
+++ b/bin/classes/Handler.js
@@ -4,10 +4,6 @@
*
* @module package/quiqqer/discount/bin/classes/Handler
* @author www.pcsg.de (Henning Leutz)
- *
- * @require qui/QUI
- * @require qui/classes/DOM
- * @require Ajax
*/
define('package/quiqqer/discount/bin/classes/Handler', [
diff --git a/bin/controls/DiscountEdit.js b/bin/controls/DiscountEdit.js
index 9c2a53d..bd60e79 100644
--- a/bin/controls/DiscountEdit.js
+++ b/bin/controls/DiscountEdit.js
@@ -1,6 +1,7 @@
/**
* Discount edit control
*
+ * @module package/quiqqer/discount/bin/controls/DiscountEdit
* @author www.pcsg.de (Henning Leutz)
*
* @event onLoaded
@@ -123,7 +124,6 @@ define('package/quiqqer/discount/bin/controls/DiscountEdit', [
var self = this;
require(['utils/Controls'], function (Utils) {
-
var Elm = self.getElm(),
Form = Elm.getElement('form');
@@ -194,7 +194,7 @@ define('package/quiqqer/discount/bin/controls/DiscountEdit', [
Scope.addEvent('change', function (event) {
var value = event.target.value;
- if (parseInt(value) == Discounts.DISCOUNT_SCOPE_TOTAL) {
+ if (parseInt(value) === Discounts.DISCOUNT_SCOPE_TOTAL) {
showVatRow();
return;
}
diff --git a/bin/controls/search/Result.js b/bin/controls/search/Result.js
index 230cf5a..b7a540a 100644
--- a/bin/controls/search/Result.js
+++ b/bin/controls/search/Result.js
@@ -3,11 +3,6 @@
* @module package/quiqqer/discount/bin/controls/search/Search
* @author www.pcsg.de (Henning Leutz)
*
- * @require qui/QUI
- * @require qui/controls/Control
- * @require qui/controls/buttons/Button
- * @require package/quiqqer/discount/bin/classes/Handler
- *
* @event onLoaded
* @event onDblClick [self]
*/
@@ -144,7 +139,6 @@ define('package/quiqqer/discount/bin/controls/search/Result', [
* event : on inject
*/
$onInject: function () {
-
this.fireEvent('loaded');
},
diff --git a/bin/controls/search/Search.js b/bin/controls/search/Search.js
index 703bea5..82250e0 100644
--- a/bin/controls/search/Search.js
+++ b/bin/controls/search/Search.js
@@ -3,11 +3,6 @@
* @module package/quiqqer/discount/bin/controls/search/Search
* @author www.pcsg.de (Henning Leutz)
*
- * @require qui/QUI
- * @require qui/controls/Control
- * @require qui/controls/buttons/Button
- * @require package/quiqqer/discount/bin/classes/Handler
- *
* @event onLoaded
*/
define('package/quiqqer/discount/bin/controls/search/Search', [
@@ -73,7 +68,6 @@ define('package/quiqqer/discount/bin/controls/search/Search', [
* @return {Promise}
*/
search: function () {
-
var Form = this.getElm().getElement('form');
var data = Object.filter(QUIFormUtils.getFormData(Form), function (value) {
@@ -81,13 +75,7 @@ define('package/quiqqer/discount/bin/controls/search/Search', [
});
return new Promise(function (resolve, reject) {
-
- Discounts.search(data).then(function (result) {
-
- resolve(result);
-
- }).catch(reject);
-
+ Discounts.search(data).then(resolve).catch(reject);
});
}
});
diff --git a/bin/controls/search/Window.js b/bin/controls/search/Window.js
index edb216d..473969b 100644
--- a/bin/controls/search/Window.js
+++ b/bin/controls/search/Window.js
@@ -2,11 +2,6 @@
*
* @module package/quiqqer/discount/bin/controls/search/Search
* @author www.pcsg.de (Henning Leutz)
- *
- * @require qui/QUI
- * @require qui/controls/Control
- * @require qui/controls/windows/Confirm
- * @require package/quiqqer/discount/bin/classes/Handler
*/
define('package/quiqqer/discount/bin/controls/search/Window', [
@@ -207,7 +202,6 @@ define('package/quiqqer/discount/bin/controls/search/Window', [
this.Loader.show();
this.$Search.search().then(function (result) {
-
self.Loader.hide();
self.$Result.setData({
@@ -259,7 +253,6 @@ define('package/quiqqer/discount/bin/controls/search/Window', [
self.$Result.resize();
}
});
-
}
});
});
--
GitLab